---- Reported by jim@yorba.org 2013-02-05 13:54:00 -0800 ----

Original Redmine bug id: 6334
Original URL: http://redmine.yorba.org/issues/6334
Searchable id: yorba-bug-6334
Original author: Jim Nelson
Original description:

Now that multiple accounts has landed, we should display a From: line in the
composer window to indicate which account the message is being sent from.

For new messages, the From: line should be a combo box allowing the user to
select which account to send from. The default should be whichever account was
selected when the New Message button was pressed.

For replies and forwards, the From: line should be a static label. We may in
the future allow the user to change accounts when replying or forwarding a
message.

If only one account is registered for Geary, no From: line should be shown.

Related issues:
related to geary - 6396: Autocomplete seems to be tied to account
selected in side... (Fixed)



---- Additional Comments From geary-maint@gnome.bugs 2013-05-01 11:48:00 -0700 ----

### History

####

#1

Updated by Eric Gregory 10 months ago

We decided for this ticket that if an account is deleted while a reply or
forward is open, they will get an error message. That way they have a chance
to save the message before it's gone for good.

####

#2

Updated by Eric Gregory 10 months ago

  * **Status** changed from _Open_ to _Review_

Ready for review at bug/6334-show-from

####

#3

Updated by Jim Nelson 10 months ago

  * **Status** changed from _Review_ to _Open_

Looks good! Only a couple of small things:

  * I think AccountInformation should return a MailboxAddress that is constructed from its real_name and email address. MailboxAddress.get_full_address() can then be used instead of pretty_string(). This will be useful elsewhere and means MailboxAddress holds all the logic for constructing email strings.
  * Looking at the various Accounts panes, I notice some similarities and differences between them. One thing I see is that they're using different spacings (some 6, others 4). Is this intentional? Would it make sense to create an AccountPage class that accepts a .glade filename as a ctor argument that does all the work of loading the file and setting up the Gtk.Box. Subclasses would then only need to hook up signals and initial widgets. If this doesn't make sense, let me know.

####

#4

Updated by Eric Gregory 10 months ago

  * **Status** changed from _Open_ to _5_

Applied in changeset f604d2d988b3c8ab9cd3c294701e640da2090339.

####

#5

Updated by Jim Nelson 10 months ago

  * **Resolution** set to _fixed_

####

#6

Updated by Eric Gregory 10 months ago

  * **Status** changed from _5_ to _Open_
  * **Resolution** deleted (<strike>_fixed_</strike>)

Somehow I accidentally committed the changes before they were complete.
Fortunately it doesn't actually **break** anything, but we've decided to
replace pretty_string() with a method that returns a MailboxAddress as
suggested above.

Re-opening.

####

#7

Updated by Eric Gregory 10 months ago

  * **Status** changed from _Open_ to _Review_

Ready for review at bug/6334-show-from-mark-ii

####

#8

Updated by Jim Nelson 10 months ago

Commit!

####

#9

Updated by Eric Gregory 10 months ago

  * **Status** changed from _Review_ to _5_

Applied in changeset 666143e5b2aa991d73cf294d44d5410d1ad3f3b3.

####

#10

Updated by Eric Gregory 10 months ago

  * **Resolution** set to _fixed_

####

#11

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-21 20:28 UTC  ---

This bug was previously known as _bug_ 6334 at http://redmine.yorba.org/show_bug.cgi?id=6334

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.