After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 71414 - pango configure lacks --disable-modules
pango configure lacks --disable-modules
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
0.23
Other Linux
: High normal
: Small feature
Assigned To: pango-maint
pango-maint
Depends on: 71411
Blocks:
 
 
Reported: 2002-02-13 21:02 UTC by Sven Neumann
Modified: 2006-01-16 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch. (16.17 KB, patch)
2005-10-01 10:38 UTC, Behdad Esfahbod
committed Details | Review

Description Sven Neumann 2002-02-13 21:02:46 UTC
To be able to build static binaries using Pango, a --disable-modules
configure switch is needed. Similar to how it works for pixbuf modules
in GTK+ this would allow people to include the shaper modules they
need (using --with-included-modules).
Comment 1 Owen Taylor 2002-02-13 22:43:31 UTC
Why can't you just not install/distribute the dynamic modules
if you don't want them?
Comment 2 Sven Neumann 2002-02-14 13:41:07 UTC
I could but I'm trying to keep the changes needed for our buildsystem
as small as possible. IMO others would also benefit from a 
--disable-modules option. It is not a showstopper however...
Comment 3 Owen Taylor 2002-02-14 23:18:57 UTC
I think what people would expect would be
 
 --with-dynamic-modules
 --without-dynamic-modules
 --with-dynamic-modules=tamil-xft

The first two are a small pain to implement, the third one
a major pain. But if we don't do that then there is a weird
inconsistency.
Comment 4 Behdad Esfahbod 2005-10-01 10:38:12 UTC
Created attachment 52904 [details] [review]
Patch.

Attaching patch.  Works here, didn't test extensively though.
Comment 5 Behdad Esfahbod 2005-10-01 10:39:27 UTC
The patch defines automake conditional HAVE_DYNAMIC_MODULES.  I think we may as
well use that to decide whether define ENABLE_ENGINE.
Comment 6 Behdad Esfahbod 2005-10-05 00:19:44 UTC
Stepping up priority because of the patch.
Comment 7 Behdad Esfahbod 2006-01-16 10:10:04 UTC
2006-01-16  Behdad Esfahbod  <behdad@gnome.org>

        Fixes bug #71414, allowing to disable building/installing modules.

        * configure.in: Add support for --with-dynamic-modules.

        * */Makefile.am: Adapt to the above change.