After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 713983 - Remove draft when UIDPLUS is not present
Remove draft when UIDPLUS is not present
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client+engine
master
Other All
: High normal
: 0.6.1
Assigned To: Geary Maintainers
Geary Maintainers
: 726665 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-09-16 11:56 UTC by Jim Nelson
Modified: 2014-08-12 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 20:23:55 UTC


---- Reported by jim@yorba.org 2013-09-16 16:56:00 -0700 ----

Original Redmine bug id: 7495
Original URL: http://redmine.yorba.org/issues/7495
Searchable id: yorba-bug-7495
Original author: Jim Nelson
Original description:

If the server doesn't support UIDPLUS, it doesn't respond with an APPENDUID
when saving a draft, which is crucial for our current implementation of
deleting an old draft message. We need to come up with a backup mechanism for
detecting which message is a particular saved draft so it can be deleted by
the composer later.

Related issues:
related to geary - Feature #7479: Support Outlook.com IMAP (Fixed)



--- Bug imported by chaz@yorba.org 2013-11-21 20:24 UTC  ---

This bug was previously known as _bug_ 7495 at http://redmine.yorba.org/show_bug.cgi?id=7495

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Charles Lindsay 2014-03-18 22:56:10 UTC
*** Bug 726665 has been marked as a duplicate of this bug. ***
Comment 2 Charles Lindsay 2014-03-18 23:00:04 UTC
This is really something we should work on soon.  As Robert reported in the duplicate bug above, Geary just fills up the drafts folder with a huge number of worthless messages.  It affects the zoho service, and probably others we don't know about.  It also affects Outlook.com, although in that case we just disable drafts entirely.  (Once we nail this ticket down, we should also re-enable drafts for Outlook.com.)
Comment 3 Charles Lindsay 2014-03-20 00:25:14 UTC
Robert, I've got a branch up at wip/uidplus-drafts-726665 that should prevent Geary from saving drafts in your case.  It's not ideal obviously, since you just won't have drafts at all, but should at least prevent you from having to go back and delete a million drafts after you compose a message.  If you feel comfortable building from git, feel free to test that out and let us know if it does indeed fix the problem for you.

Otherwise, we still need to fix *this* bug, as my patch is just a bandaid on the symptoms.
Comment 4 Robert Bevan-Jones 2014-03-20 08:13:29 UTC
When it comes to the underbelly of Linux, Charles, I've always been a wonder-struck bystander, posting the occasional bug report or donation but otherwise standing back.  I did compile some applications from source when I first came to Linux in the late 90s, but that sometimes produced unwanted side-effects!

But I really like Geary, and would be pleased to help you and the rest of the team make it better.  However, since the "no Drafts at all" patch version you offered me is just a bandaid, I think I'll stay put with what I've got.

I would be happy to test a bug-fix version of Geary, though.  I've never built directly from git before, but there's a first time for everything!

Is it worthwhile me taking a back-up of geary.db (from ~/.local/cache/...), just to be on the safe side with all of this?
Comment 5 Charles Lindsay 2014-03-20 17:58:29 UTC
That's no problem.

Since we don't have a bugfix version yet, I don't think there's a need to back up your database.  If/when we make one and if you want to test it, it could be worthwhile to back up your database first, but since Geary is only caching what it sees on IMAP, the only purpose served by backing up the database is to save you from having to download your mail again -- there's no risk of losing data unless you have messages stuck in your outbox.
Comment 6 Jim Nelson 2014-03-29 00:57:49 UTC
Robert, I'd like to land this, but not unless we've tested it or heard from a user that this fixes their problem.  If building it is a problem, is there a possibility of you sending us a test account on your server?  That would be the easiest way for us to verify the fix.

If you can, please email the username/password to geary@yorba.org.  Thanks!
Comment 7 Jim Nelson 2014-04-04 20:04:18 UTC
Thanks to Robert I was able to verify this works on servers lacking UIDPLUS support.

Pushed to master, commit 730b33
Comment 8 Mike 2014-06-16 17:17:21 UTC
Any way to know what version this will land in? I have 0.6 and see symptoms of this bug...want to know if I should upgrade or report it.
Comment 9 Jim Nelson 2014-06-17 19:27:08 UTC
This is in master.  We need to release a Geary 0.6.1 that would include this fix.