GNOME Bugzilla – Bug 713492
Support well-known names for special folders
Last modified: 2014-10-22 21:09:40 UTC
---- Reported by geary-maint@gnome.bugs 2013-08-21 14:38:00 -0700 ---- Original Redmine bug id: 7380 Original URL: http://redmine.yorba.org/issues/7380 Searchable id: yorba-bug-7380 Original author: Timo Kluck Original description: Even for servers that don't support XLIST or SPECIAL-USE (see #6070), it is possible to use the well-known names such as 'Sent' or 'INBOX.Sent' and treat them as special folders. This is pretty standard for clients, at least according to a Dovecot developer (see http://www.dovecot.org/list/dovecot/2011-December/062390.html). Thunderbird, at least, seems to do this. Related issues: related to geary - Feature #6070: Support SPECIAL-USE extension (Open) ---- Additional Comments From geary-maint@gnome.bugs 2013-09-23 15:29:00 -0700 ---- ### History #### #1 Updated by Timo Kluck 3 months ago This is now: https://gitorious.org/geary/geary/commits/redmine_7380_well-known-special- folder-names #### #2 Updated by Charles Lindsay 3 months ago * **Status** changed from _Open_ to _Review_ #### #3 Updated by Jim Nelson 3 months ago * **Category** changed from _engine_ to _server-support_ * **Priority** changed from _Low_ to _Normal_ * **Target version** set to _0.4.0_ Timo, your patch seems a good start. Some things I'd like to discuss before landing this: * This patch only looks for folders beneath Inbox. How common is this practice? * Are we so certain we can look for untranslated special folder names? The email you link from says such translation should be done at the MUA but doesn't give any documentation to support that. I'm unfamiliar with Dovecot/Cyrus/Courier well-known practices here; do they expect a sysadmin in Germany to label the special folders in English? * Do we know that a special folder named "Sent" is filled by the server and doesn't require the client to push sent messages to it? Since Geary doesn't offer this yet, I feel like we'd be exposing ourselves a little bit to show a Sent Mail folder that doesn't show the mail Geary is sending. Maybe the real question I have is, if we land this patch, how many servers out there installed with a few reasonable configuration changes will receive its benefit? I'm always concerned about hardcoding paths. #### #4 Updated by Jim Nelson 3 months ago * **Status** changed from _Review_ to _Need Information_ #### #5 Updated by Jim Nelson about 1 month ago * **Target version** changed from _0.4.0_ to _0.5.0_ --- Bug imported by chaz@yorba.org 2013-11-21 20:21 UTC --- This bug was previously known as _bug_ 7380 at http://redmine.yorba.org/show_bug.cgi?id=7380 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
After many trials and tribulations, this is ready for review at wip/create-folders-713492. We use the special-use or xlist data when available. When it's not available, we supply a localized list of folder names to use as special folders, which get searched for in the root or under the inbox. If those match, they're recorded in the account information so we always come back to it without searching in the future. When no matching folders are found, we create the one given at the beginning of the list of names.
A lot of changes, but everything seems in order. A few things: * Please add Valadoc to AccountInformation.get_special_folder_path() and AccountInformation.set_special_folder_path() that they only accept paths for DRAFTS, SENT, SPAM, and TRASH. * There's a problem with the changes to OutlookAccount.new_folder(): we do not support Drafts with Outlook.com at this time due to their server's not supporting UIDPLUS. This is one reason why CreateFolder is an optional interface. I forgot about this problem. Let's discuss how we can work around this problem. * In the comments for get_required_special_folder(), please make sure it's clear that the folder will be created on the server if it doesn't already exist; when I first read it, I thought it meant create a Folder object, but this method goes beyond that.
Commit!
Fixed in commit 4552757.
Works great, thanks. Should Archive(s) also be a special folder?
It is, but Geary doesn't have any explicit support for Archive yet. That's ticketed at bug #713986.
Geary isn't picking all special folders on my work email server: "Sent Items" for send and "Deleted Items" for trash. It matches drafts. It does seem to find both of these under Labels (as "Deleted Items" and "Sent Items". It's an exchange server accessible through IMAP, so I'd have thought the names are relatively common patterns?
An unfortunate double-whammy, Geary isn't detecting up special folders for one of my personal email accounts, either. It finds Inbox, but not drafts, sent, etc. This account has all these as subfolders of INBOX. (which is the root IMAP folder). Within this they are just named "drafts" and "sent". It's hosted via Dreamhost.com, which is a fairly popular hosting company. Not sure whether this should be a reopening of this bug (as they might be considered common names) or supporting motivation for bug #714106