---- Reported by geary-maint@gnome.bugs 2013-08-27 11:57:00 -0700 ----

Original Redmine bug id: 7403
Original URL: http://redmine.yorba.org/issues/7403
Searchable id: yorba-bug-7403
Original author: Yosef Or Boczko
Original description:

In LTR language (e.g. English), in the header of message, in **left** have
avatar,

and after the avatar, in the right have the addresses.

In RTL language (e.g. Hebrew), in the header of message, in **right** need to
be avatar,

and after the avatar, to left of the avatar, need to be the addresses.

I guess (in RTL language) also the 'Star' button and the button with the 'go-
down-symbolic' symbolic

need to be after the addresses, in left of the addresses.

Now, the header of message in RTL language is same to LTR language.

See images (screenshot in LTR and in TRL language).



---- Additional Comments From geary-maint@gnome.bugs 2013-09-25 18:24:00 -0700 ----

### History

####

#1

Updated by Avi Levy 3 months ago

There may be a pure-CSS fix for this issue. To start investigating, run `geary
--inspector` and right click on the message to open up the Webkit inspector.

####

#2

Updated by Yosef Or Boczko 3 months ago

I think this relevant:
http://git.yorba.org/cgit.cgi/geary/tree/src/client/views/conversation-
viewer.vala#n575

Maybe need to add <div align="right"> somewhere.

####

#3

Updated by Yosef Or Boczko 3 months ago

  * **File** 0005-Start-right-allign-the-header-of-a-message-in-RTL.patch added
  * **File** Geary-RTL-align.png added
  * **File** Geary-RTL-align2.png added

I think the patch is good start, but still have some problem with this.

I want to align to right just the header and the addresses,

not to align the content of the message.

####

#4

Updated by Jim Nelson 3 months ago

  * **Category** set to _ux_
  * **Target version** set to _0.4.0_

Robert Schroll might be able to help with this -- I suspect there's a DIV
CLASS in there some where you can use, or we can easily add one to help out.
Robert, any advice for Yosef?

####

#5

Updated by Yosef Or Boczko 3 months ago

  * **File** _0001-Fix-the-size-of-the-buttons-in-the-toolbar-in-new-GT.patch_ added

Well, this possible - see the patch.

But the patch become the function to little superfluous.

####

#6

Updated by Yosef Or Boczko 3 months ago

Oops, I comment to the wrong bug.

####

#7

Updated by Robert Schroll 3 months ago

If you want to affect only the header, you should target either
.header_container (which contains everything above the body) or .header (just
the from, to, subject, date lines). But a lot of this layout is done with
floats, and it doesn't seem that changing their containers changes how these
things are floated. My suggestion, having not thought about it in any detail,
would be to add a "rtl" class to something (don't know if it should be the
.email_container or the .header_container) and add a bunch of CSS rules that
reverse the direction of the floats when this class is in effect.

As Avi said, the inspector is a great way to explore what's going on and
experiment with layout options.

####

#8

Updated by Jim Nelson 3 months ago

  * **File** deleted (<strike>_0001-Fix-the-size-of-the-buttons-in-the-toolbar-in-new-GT.patch_</strike>)

####

#9

Updated by Jim Nelson 3 months ago

I deleted the patch because it's for #7394.

####

#10

Updated by Yosef Or Boczko 3 months ago

  * **File** 0001-Start-right-allign-the-header-of-a-message-in-RTL.patch added

I attached a patch for align just the header of the message.

But the patch not make some stuff:

- The avatar is still in left of the header,  
- The Star/Unstar button and the menu button  
still in the right of the header.

And more problem:

- The date need to align to right, but is align to left.  
- The title of the message need to align to right if the  
content of the title is start in character of language RTL

(for example, character in Hebrew), and align to left

if the content of the title is start in character of language RTL

(for example, character in English).

Now, the title is always align to left.

- If the length of the title is requires broke line,  
all the title is align to right, also if the string of

the title is in English.

####

#11

Updated by Jim Nelson 3 months ago

Yosef, are you suggesting we take this patch now and fix these other problems
later? Or do you want to keep working on this?

####

#12

Updated by Yosef Or Boczko 3 months ago

Now, I suggesting not get the patch, because the patch just move the

"From:", "To:", "Cc", "Subject:", "Date:" and more to place right, but is

broken title message too long in English (see Geary-RTL-align2.png above).

####

#13

Updated by Jim Nelson 3 months ago

Yosef, we'll reach string freeze in a little over two weeks' time. Do you
think this change will change user-visible (i.e. translatable) strings?

####

#14

Updated by Yosef Or Boczko 3 months ago

No, I not think.

####

#15

Updated by Jim Nelson about 1 month ago

  * **Target version** changed from _0.4.0_ to _0.5.0_

####

#16

Updated by Yosef Or Boczko about 1 month ago

I think I need a help to deal with the problem.

####

#17

Updated by Jim Nelson about 1 month ago

What kind of help do you need?



--- Bug imported by chaz@yorba.org 2013-11-21 20:21 UTC  ---

This bug was previously known as _bug_ 7403 at http://redmine.yorba.org/show_bug.cgi?id=7403
Imported an attachment (id=260703)
Imported an attachment (id=260704)
Imported an attachment (id=260705)
Imported an attachment (id=260706)
Imported an attachment (id=260707)
Imported an attachment (id=260708)

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution