After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 713430 - convert email addresses in plain text messages to hyperlinks
convert email addresses in plain text messages to hyperlinks
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
unspecified
Other All
: High normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2012-03-17 05:29 UTC by Adam Dingle
Modified: 2014-10-21 03:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Enable GMime.FILTER_HTML_CONVERT_ADDRESSES (2.25 KB, patch)
2014-10-15 21:20 UTC, Robert Schroll
committed Details | Review

Description Charles Lindsay 2013-11-21 20:20:06 UTC


---- Reported by adam@yorba.org 2012-03-17 10:29:00 -0700 ----

Original Redmine bug id: 4861
Original URL: http://redmine.yorba.org/issues/4861
Searchable id: yorba-bug-4861
Original author: Adam Dingle
Original description:

If a plain text message in Geary contains one or more email addresses, Geary
should notice those addresses and convert them to hyperlinks. If I click one
of those links, Geary should open a Compose window that lets me compose email
to that address.

(Note that this already works in Geary for HTML messages whose senders have
converted email addresses to mailto: links.)

Related issues:
related to geary - 4849: commit incorrectly recognized as URL (Fixed)
related to geary - 5781: Convert email addresses in composer to mailto
links (Open)



---- Additional Comments From geary-maint@gnome.bugs 2013-03-01 18:02:00 -0800 ----

### History

####

#1

Updated by Adam Dingle over 1 year ago

  * **Tracker** changed from _Bug_ to _Feature_

####

#2

Updated by Adam Dingle over 1 year ago

  * **Target version** deleted (<strike>_0.1_</strike>)

####

#3

Updated by Jim Nelson about 1 year ago

  * **Category** set to _client_

Note that this is for converting email addresses in the conversation viewer.
There is a similar issue in the composer at #5781.

####

#4

Updated by Robert Schroll 9 months ago

The GMime.FilterHTML we're switching to in #5482 can do this, with the
FILTER_HTML_CONVERT_ADDRESSES flag. Unfortunately, it's pretty broken before
the recent 2.6.14 release. So when we can require GMime 2.6.14, this'll have
an easy fix. Until then, we'll have to do it ourselves.



--- Bug imported by chaz@yorba.org 2013-11-21 20:20 UTC  ---

This bug was previously known as _bug_ 4861 at http://redmine.yorba.org/show_bug.cgi?id=4861

Unknown version " in product geary. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Robert Schroll 2014-10-15 21:20:48 UTC
Created attachment 288618 [details] [review]
Enable GMime.FILTER_HTML_CONVERT_ADDRESSES

This works every since 2.6.14, which was released in Febrary of last 
year.  I'd hope that everyone who has GTK 3.10 also has GMime 2.6.14 or 
higher.

I've upped the GMime requirements, but I don't know if that's really 
necessary.  Previous versions will work, but email addresses won't be 
properly linkified.  Arguably that's better than not being allowed to 
compile it.
Comment 2 Jim Nelson 2014-10-21 01:59:26 UTC
Review of attachment 288618 [details] [review]:

Let's bump the version number as you suggest.  It will burn us if someone complains a year from now about a link not being converted only to discover after much hairpulling that they're using an old version of GMime.

Commit!
Comment 3 Robert Schroll 2014-10-21 03:00:41 UTC
Attachment 288618 [details] pushed as 770234c - Enable GMime.FILTER_HTML_CONVERT_ADDRESSES