GNOME Bugzilla – Bug 713202
make clean and distclean doesn't remove valadoc/ directory
Last modified: 2018-06-13 12:53:04 UTC
---- Reported by jim@yorba.org 2013-05-17 18:04:00 -0700 ---- Original Redmine bug id: 6965 Original URL: http://redmine.yorba.org/issues/6965 Searchable id: yorba-bug-6965 Original author: Jim Nelson Original description: Debatable if "make clean" should remove it, but "make distclean" has to. --- Bug imported by chaz@yorba.org 2013-11-21 20:19 UTC --- This bug was previously known as _bug_ 6965 at http://redmine.yorba.org/show_bug.cgi?id=6965 Unknown version " in product geary. Setting version to "!unspecified". Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
I guess this is about valadoc.dir: [geary (master=)]$ find . -name valadoc* ./build/src/CMakeFiles/valadoc.dir [geary (master=)]$ ls build/src/CMakeFiles/valadoc.dir/ build.make cmake_clean.cmake DependInfo.cmake progress.make After running `make clean` these files are still there. `make distclean` cleans all the build/ directory. Probably when Jim wrote that comment, the build was set up differently. I guess that this should be fixed after moving to meson? Mike, can you add a dep on bug #777044?
Currently, the Meson build is generating it (if valadoc is enabled) in build/src/valadoc, so it will be deleted by distclean if that deletes the build dir. It's handy having a "known good" copy outside of the build directory though in case the build fails, so maybe the compat Makefile should (like for the binaries) copy it to the source dir when made and delete it on distclean? Added the dep, cheers!
The meson build generates valadoc in build, and while the convenience make file will still copy it to the source root, it will also delete it on make distclean. So resolving as fixed.