---- Reported by eric@yorba.org 2013-06-14 18:51:00 -0700 ----

Original Redmine bug id: 7104
Original URL: http://redmine.yorba.org/issues/7104
Searchable id: yorba-bug-7104
Original author: Eric Gregory
Original description:

When doing a Ctrl-F search, the conversation viewer doesn't jump to the first
match. This can be confusing since the first match might be a few pages down.

Let's change the find bar to jump to the first match as the user types, just
like Firefox, Gedit, etc.

Related issues:
related to geary - Feature #7105: Next/prev buttons for search (Open)



---- Additional Comments From geary-maint@gnome.bugs 2013-10-03 17:53:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 4 months ago

  * **Category** changed from _client_ to _ux_

####

#2

Updated by Wolfgang Steitz 3 months ago

  * **File** 7104_1.diff added

attached patch.

####

#3

Updated by Eric Gregory 3 months ago

  * **Status** changed from _Open_ to _Review_

####

#4

Updated by Jim Nelson 3 months ago

  * **Status** changed from _Review_ to _Open_

Wolfgang, this is close but not quite there. The problem is that the find()
method maintains state of the current selection, and some times calling it
will jump to a new selection without needing to. To illustrate:

  * Use Ctrl+F to find a string that's present a few times in the conversation.
  * Start typing to match that string. The first one is selected; that's good. ("conversa")
  * Add some garbage characters that invalidate the current selection. The selection disappears. ("conversaxx")
  * Now backspace to return to the good characters. ("conversa")

At this point, the selection has jumped to the next mention of the string
"conversa". It should stay at the current selection. I verified that this is
the behavior in Firefox (and probably in other apps as well).

This is subtle, but would like to get this right. I suspect a simple tweak to
find() will solve this problem (while not changing the behavior of the next
button, etc.)

####

#5

Updated by Wolfgang Steitz 3 months ago

I see, the current behavior is definitely strange. I will have a look at this.

While trying this in other apps, google chrome and epiphany work different in
the situation. both jump to the first match from the top. Actually chrome and
epiphany always start with the first match from the top. while in geary, doing
a new search starts from the previous position.

####

#6

Updated by Jim Nelson 3 months ago

I didn't look at any other apps, but that was something else that occurred to
me. I would prefer starting from the top as well.

####

#7

Updated by Charles Lindsay about 1 month ago

  * **Target version** changed from _0.4.0_ to _0.5.0_



--- Bug imported by chaz@yorba.org 2013-11-21 20:19 UTC  ---

This bug was previously known as _bug_ 7104 at http://redmine.yorba.org/show_bug.cgi?id=7104
Imported an attachment (id=260576)

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution