After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 713089 - Conversation list context menu remains when conversation is removed
Conversation list context menu remains when conversation is removed
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client
master
Other All
: Low normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 730682
Blocks:
 
 
Reported: 2013-06-20 01:24 UTC by Eric Gregory
Modified: 2019-01-15 06:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 20:18:59 UTC


---- Reported by eric@yorba.org 2013-06-19 18:24:00 -0700 ----

Original Redmine bug id: 7126
Original URL: http://redmine.yorba.org/issues/7126
Searchable id: yorba-bug-7126
Original author: Eric Gregory
Original description:

* Right-click on a conversation in the conversation list to bring up the context menu
  * On a different machine, use any mail client to archive/delete/move that conversation

Note that the context menu remains, but some of the items are insensitive.
Mark as read/unread and Star are still sensitive, but do not mark or star the
removed message.

Related issues:
related to geary - 7129: Inconsistent behavior in conversation list
context menu w... (Fixed)



---- Additional Comments From geary-maint@gnome.bugs 2013-07-11 15:32:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 5 months ago

  * **Target version** set to _0.4.0_

It might be a tad annoying, but I think Geary should dismiss the context menu
if the conversation list changes. I'm open to other suggestions.

####

#2

Updated by Eric Gregory 5 months ago

  * **Status** changed from _Open_ to _Review_
  * **Assignee** set to _Eric Gregory_

Ready for review at bug/7126-context-menu-hide

> It might be a tad annoying, but I think Geary should dismiss the context
menu if the conversation list changes. I'm open to other suggestions.

That seemed too rough. I did one better and only dismiss the context menu if
the conversation it represents is removed.

Now all that said, whether this solution is correct depends how we want to go
about resolving #7129

####

#3

Updated by Jim Nelson 5 months ago

Eric Gregory wrote:

> That seemed too rough. I did one better and only dismiss the context menu if
the conversation it represents is removed.

I thought about that, but worried that if the conversation moved out from
under the context menu, the user would be disoriented, or even think they were
operating on a different conversation.

I'll take a look at your patch though and see what I think.

####

#4

Updated by Jim Nelson 5 months ago

  * **Status** changed from _Review_ to _Open_

Ummm ... ok. If a conversation other than the one the context menu is working
on is removed, the conversation list shifts but the context menu remains open.
If the user selects something from the context menu, it affects the proper
conversation. And, with this patch, if the context conversation is removed,
the menu is dismissed.

I still wonder, however. If a lot of messages come in at once, the
conversation list could shift so much that the conversation being affected is
not on the screen.

I think we should go with my original suggestion. It doesn't seem right to me
that an active context menu could be operating on an element off-screen or not
even under the menu itself.

####

#5

Updated by Eric Gregory 5 months ago

I'd rather not close the context menu in that case, it's going to be confusing
for the user. If a user takes a positive action to make a menu, window, etc.
appear, ideally it shouldn't disappear due to a background task. I know if I
saw that I'd assume it was a bug.

####

#6

Updated by Jim Nelson 5 months ago

We should have a design meeting to discuss the right course of action then.
Since this is Low priority (and rightly so, I think), let's move on to other
things and return to this later.

####

#7

Updated by Jim Nelson 5 months ago

  * **Assignee** deleted (<strike>_Eric Gregory_</strike>)

####

#8

Updated by Jim Nelson 4 months ago

  * **Target version** changed from _0.4.0_ to _0.5.0_



--- Bug imported by chaz@yorba.org 2013-11-21 20:19 UTC  ---

This bug was previously known as _bug_ 7126 at http://redmine.yorba.org/show_bug.cgi?id=7126

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Charles Lindsay 2014-03-18 01:38:50 UTC
This branch moved to wip/713089-context-menu-hide with the move to GNOME.
Comment 2 Michael Gratton 2019-01-15 06:40:20 UTC
Resolving as obsolete all bugs that should be resolved by the conversation list redesign (https://bugzilla.gnome.org/show_bug.cgi?id=730682). I'd mark them as a duplicate, but bz won't let me :(

Apologies for the noise.