After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712820 - sasl: Fix auth when using the PLAIN method
sasl: Fix auth when using the PLAIN method
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-21 15:29 UTC by Christophe Fergeau
Modified: 2014-01-23 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sasl: Fix auth when using the PLAIN method (1.46 KB, patch)
2013-11-21 15:29 UTC, Christophe Fergeau 		none Details | Review

Description Christophe Fergeau 2013-11-21 15:29:39 UTC 
sasl_client_start() can return SASL_OK, in which case calling
sasl_client_step() returns an error. If sasl_client_start() returned
SASL_OK and the remote told us auth is complete, we can break out of the
stepping loop early.
The upstream documentation is not very explicit about what to do when
sasl_client_start() returns SASL_OK but this was clarified by
http://asg.andrew.cmu.edu/archive/message.php?mailbox=archive.cyrus-sasl&msg=10104

This is based on a spice-gtk patch from Dietmar Maurer:
http://lists.freedesktop.org/archives/spice-devel/2013-October/015122.html
Comment 1 Christophe Fergeau 2013-11-21 15:29:52 UTC 
Created attachment 260456 [details] [review]
sasl: Fix auth when using the PLAIN method
Comment 2 Daniel P. Berrange 2014-01-23 12:02:05 UTC 
Fixed as

commit 9dd4da1609e5619f46b3c1627fc59a68735c4360
Author: Christophe Fergeau <cfergeau@redhat.com>
Date:   Thu Nov 21 16:07:28 2013 +0100

    sasl: Fix auth when using the PLAIN method


nb, i used the variant you did for the libvirt code rather than the one in this bug