After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712805 - subparse: crashes when loading a sami subtitle
subparse: crashes when loading a sami subtitle
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal critical
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-21 13:06 UTC by Jihyun Cho
Modified: 2013-11-21 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avoid null pointer access (800 bytes, patch)
2013-11-21 13:13 UTC, Jihyun Cho 		committed Details | Review

Description Jihyun Cho 2013-11-21 13:06:34 UTC 
Sami subparse has a NULL pointer access bug. When trying to split html attributes in 'html_context_handle_element' function, the problem occurs if a character '=' is used as a attribute value or comments. So below tags will crash.

<!--
=======
foo bar
=======
-->

<Sync Start="0"><P Class="FOO===">
Test
Comment 1 Tim-Philipp Müller 2013-11-21 13:11:56 UTC 
Thanks for the bug report. Are you working on a patch?
Comment 2 Jihyun Cho 2013-11-21 13:13:20 UTC 
Created attachment 260428 [details] [review]
avoid null pointer access

This patch will fix null pointer access. I tested some subtitles, and there was no problem.
Comment 3 Tim-Philipp Müller 2013-11-21 16:35:53 UTC 
Thanks for the patch, pushed to master:

commit 60e87090eb1f91e298f4e1005a6f6953b592709f
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu Nov 21 16:34:25 2013 +0000

    tests: add unit test for samiparser issue
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712805

commit a81b2380cfcb3dc97eca08318b1b405e477ec8f1
Author: Jihyun Cho <jihyun.jo@gmail.com>
Date:   Thu Nov 21 22:04:46 2013 +0900

    subparse: fix null pointer access in sami parser
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712805

Will also cherry-pick this into 1.2