After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712753 - viewSelector: Don't pages until they need to be visible
viewSelector: Don't pages until they need to be visible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-20 17:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-11-21 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
viewSelector: Don't pages until they need to be visible (1.86 KB, patch)
2013-11-20 17:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-11-20 17:06:54 UTC 
This reduces the performance hit of the first overview entry
still yet. I still see some weird effects where windows seem
to snap into place, but this will need more investigation...
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-11-20 17:06:56 UTC 
Created attachment 260342 [details] [review]
viewSelector: Don't pages until they need to be visible

AppDisplay queues a deferred work to load frequently used apps when the
apps page is loaded. Unfortunately, when the overview is first opened,
all the pages start out visible and then immediately get hidden, so the
deferred work runs immediately after the first overview opening, whether
the user was going to view their frequent apps or not.

Start all pages off as hidden, and rearrange the code so that pages are
only shown when they really need to be.
Comment 2 Florian Müllner 2013-11-21 17:17:42 UTC 
Review of attachment 260342 [details] [review]:

The commit subject needs a verb ("show" probably), otherwise looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-11-21 17:50:26 UTC 
Indeed it does. Fixed and pushed.