After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712704 - Port to GTask
Port to GTask
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-19 17:47 UTC by Debarshi Ray
Modified: 2013-12-19 02:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port gdk_pixbuf_new_from_stream_[at_scale_]async to GTask (4.97 KB, patch)
2013-11-19 17:48 UTC, Debarshi Ray 		committed Details | Review
Port gdk_pixbuf_save_to_stream_async to GTask (3.66 KB, patch)
2013-11-19 18:21 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-11-19 17:47:07 UTC 
The current GLib requirement is high enough for us to be able to use GTask.

GTask (particularly see g_task_set_return_on_cancel) lets you add cancellability to uncancellable tasks, which would be useful in some cases. See bug 712599

Other than that GTask is a much more simpler and cleaner API than GSimpleAsyncResult, which is deprecated.
Comment 1 Debarshi Ray 2013-11-19 17:48:30 UTC 
Created attachment 260269 [details] [review]
Port gdk_pixbuf_new_from_stream_[at_scale_]async to GTask
Comment 2 Debarshi Ray 2013-11-19 18:21:15 UTC 
Created attachment 260273 [details] [review]
Port gdk_pixbuf_save_to_stream_async to GTask
Comment 3 Matthias Clasen 2013-12-19 02:29:23 UTC 
Attachment 260269 [details] pushed as cd64cd3 - Port gdk_pixbuf_new_from_stream_[at_scale_]async to GTask
Attachment 260273 [details] pushed as f1f8fb6 - Port gdk_pixbuf_save_to_stream_async to GTask