After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712691 - We use application IDs instead of bus names
We use application IDs instead of bus names
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-19 15:38 UTC by Debarshi Ray
Modified: 2013-11-19 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
client: legacy: We use application IDs instead of bus names (1.49 KB, patch)
2013-11-19 15:45 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2013-11-19 15:38:50 UTC
commit abc15a8b1da35910c97f4b8542600f2e81bbbc28
Author: Christian Persch <chpe@gnome.org>
Date:   Sun May 27 14:42:02 2012 +0200

    server: Use application IDs instead of bus names
    
    Now that we use GApplication without hacks, change --bus-name to
    --app-id.

Even though we use application IDs instead of bus names now, there are some remnants of  g_dbus_is_name. Those should be replaced with g_application_id_is_valid.
Comment 1 Debarshi Ray 2013-11-19 15:45:54 UTC
Created attachment 260254 [details] [review]
client: legacy: We use application IDs instead of bus names
Comment 2 Debarshi Ray 2013-11-19 18:23:58 UTC
Comment on attachment 260254 [details] [review]
client: legacy: We use application IDs instead of bus names

Thanks for the review!