After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712640 - [Audit][Patch]Inclusion of OpenMP for engine initialisation performance increase
[Audit][Patch]Inclusion of OpenMP for engine initialisation performance increase
Status: RESOLVED INVALID
Product: GnuCash
Classification: Other
Component: Engine
2.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-18 23:20 UTC by Alex Kempster
Modified: 2018-06-29 23:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
source file (6.00 KB, patch)
2013-11-18 23:21 UTC, Alex Kempster 		rejected Details | Review

Description Alex Kempster 2013-11-18 23:20:55 UTC 
Adds the optional use of OpenMP to improve start-up time of the gnucash engine by calling any engine hooks in parallel.

diff --git a/src/engine/gnc-engine.c b/src/engine/gnc-engine.c
index 24d34db..8bdd49b 100644
--- a/src/engine/gnc-engine.c
+++ b/src/engine/gnc-engine.c

see attached for source code changes.

Please audit

Alex Kempster
Comment 1 Alex Kempster 2013-11-18 23:21:43 UTC 
Created attachment 260178 [details] [review]
source file
Comment 2 John Ralls 2013-11-19 00:16:07 UTC 
Comment on attachment 260178 [details] [review]
source file

1. No. Nothing in Gnucash is thread-safe. There's no way we're going to bring in MP, at least not until after the C++ rewrite.
 
2. That's not a patch. See http://wiki.gnucash.org/wiki/Git#Patches for how to make a patch.
Comment 3 John Ralls 2013-11-19 00:21:21 UTC 
Damn cheeky of you to change the Wiki as if your proposal had been accepted. If you want to join the team and work on the teams goals, join the development list and learn about what the goals are.
Comment 4 John Ralls 2018-06-29 23:21:34 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=712640. Please update any external references or bookmarks.