After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712638 - Fix the align and spacing in the login-screen in RTL
Fix the align and spacing in the login-screen in RTL
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 711204 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-11-18 22:51 UTC by Yosef Or Boczko
Modified: 2013-12-11 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot - the login screen in RTL (327.12 KB, image/png)
2013-11-18 22:51 UTC, Yosef Or Boczko 		  Details
userWidget: Fix the padding in RTL (897 bytes, patch)
2013-11-18 22:56 UTC, Yosef Or Boczko 		committed Details | Review
authPrompt: Explicitly set horizontal alignment (1.60 KB, patch)
2013-11-18 22:56 UTC, Yosef Or Boczko 		committed Details | Review
unlockDialog: Explicitly set horizontal alignment (1.24 KB, patch)
2013-11-18 22:57 UTC, Yosef Or Boczko 		committed Details | Review
Screenshot - the login screen in RTL (after the patch above) (327.03 KB, image/png)
2013-11-18 22:58 UTC, Yosef Or Boczko 		  Details

Description Yosef Or Boczko 2013-11-18 22:51:11 UTC 
Created attachment 260169 [details]
Screenshot - the login screen in RTL

See the screenshot of the currently login screen.
Comment 1 Yosef Or Boczko 2013-11-18 22:56:39 UTC 
Created attachment 260173 [details] [review]
userWidget: Fix the padding in RTL
Comment 2 Yosef Or Boczko 2013-11-18 22:56:55 UTC 
Created attachment 260174 [details] [review]
authPrompt: Explicitly set horizontal alignment
Comment 3 Yosef Or Boczko 2013-11-18 22:57:10 UTC 
Created attachment 260175 [details] [review]
unlockDialog: Explicitly set horizontal alignment
Comment 4 Yosef Or Boczko 2013-11-18 22:58:02 UTC 
Created attachment 260176 [details]
Screenshot - the login screen in RTL (after the patch above)
Comment 5 Yosef Or Boczko 2013-11-20 12:24:26 UTC 
*** Bug 711204 has been marked as a duplicate of this bug. ***
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-12-11 20:35:20 UTC 
Review of attachment 260173 [details] [review]:

Yes.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-12-11 20:35:27 UTC 
Review of attachment 260175 [details] [review]:

Yep.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-12-11 20:35:31 UTC 
Review of attachment 260174 [details] [review]:

OK.
Comment 9 Yosef Or Boczko 2013-12-11 20:46:45 UTC 
Review of attachment 260173 [details] [review]:

pushed as ea86c9b - userWidget: Fix the padding in RTL
Comment 10 Yosef Or Boczko 2013-12-11 20:47:22 UTC 
Review of attachment 260174 [details] [review]:

pushed as 49189e0 - authPrompt: Explicitly set horizontal alignment
Comment 11 Yosef Or Boczko 2013-12-11 20:47:45 UTC 
Review of attachment 260175 [details] [review]:

pushed as efca9e1 - unlockDialog: Explicitly set horizontal alignment