After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712616 - Password Dialog should also ask for username, not only for password
Password Dialog should also ask for username, not only for password
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
3.8.x
Other Linux
: Normal trivial
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-18 17:18 UTC by TJ
Modified: 2013-11-26 02:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Password Dialog Screenshot (5.30 KB, image/png)
2013-11-18 17:19 UTC, TJ 		  Details
A patch to fix this issue (1.01 KB, patch)
2013-11-26 00:40 UTC, Vinicius Silva 		none Details | Review

Description TJ 2013-11-18 17:18:17 UTC 
zenity --password --username provides a dialog with entry boxes for both a username and password, as shown in the attachment, and the documentation here: https://help.gnome.org/users/zenity/stable/password.html.en

The dialog text is "Type your password", but should read something like "Enter your username and password".
Comment 1 TJ 2013-11-18 17:19:22 UTC 
Created attachment 260147 [details]
Password Dialog Screenshot
Comment 2 Vinicius Silva 2013-11-26 00:40:57 UTC 
Created attachment 262800 [details] [review]
A patch to fix this issue

Hi,

I'm attaching a small patch that fixes the problem.
I added a gchar containing the original text and I check if username is being passed as a parameter, and if it is it's replaced with text asking for the username and password.

Let me know if you have any questions or suggestions.