After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712609 - Add ATSPI_STATE_CHECKABLE and ATSPI_STATE_HAS_POPUP
Add ATSPI_STATE_CHECKABLE and ATSPI_STATE_HAS_POPUP
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-18 16:28 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-11-19 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
at-spi2-core patch (1.58 KB, patch)
2013-11-18 18:45 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review
at-spi2-atk patch (1.13 KB, patch)
2013-11-18 18:53 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review
pyatspi2 patch (3.03 KB, patch)
2013-11-18 18:54 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		none Details | Review
pyatspi2 patch (1.78 KB, patch)
2013-11-18 18:55 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-11-18 16:28:38 UTC 
Two new states were added to ATK:

* ATK_STATE_CHECKABLE (see bug 712576)
* ATK_STATE_HAS_POPUP (see bug 712581)

We need corresponding states added to AT-SPI2.

ATSPI_STATE_CHECKABLE
Indicates this object has the potential to be checked, such as a checkbox or
toggle-able table cell.

ATSPI_STATE_HAS_POPUP
Indicates that the object has a popup context menu or sub-level menu which may
or may not be showing. This means that activation renders conditional content.
Note that ordinary tooltips are not considered popups in this context.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-18 18:45:06 UTC 
Created attachment 260152 [details] [review]
at-spi2-core patch
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-18 18:53:58 UTC 
Created attachment 260156 [details] [review]
at-spi2-atk patch
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-18 18:54:42 UTC 
Created attachment 260157 [details] [review]
pyatspi2 patch
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-18 18:55:37 UTC 
Created attachment 260159 [details] [review]
pyatspi2 patch

Sorry, I uploaded the wrong patch (I uploaded patch for bug 712608). This is the correct.
Comment 5 Mike Gorse 2013-11-19 16:19:28 UTC 
Comment on attachment 260156 [details] [review]
at-spi2-atk patch

Committed after fixing one of the mappings, so you might need to merge.
Comment 6 Mike Gorse 2013-11-19 16:20:55 UTC 
Committed for 2.11.2. Thanks for the patches.