After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712604 - Update g_desktop_app_info_search to additionally match on Exec= from .desktop files
Update g_desktop_app_info_search to additionally match on Exec= from .desktop...
Status: RESOLVED DUPLICATE of bug 725023
Product: glib
Classification: Platform
Component: gio
2.39.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-11-18 15:27 UTC by Frederic Peters
Modified: 2017-09-13 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make GDesktopAppInfo search use the C locale in addition of current locale (1.18 KB, patch)
2013-11-18 15:28 UTC, Frederic Peters 		none Details | Review

Description Frederic Peters 2013-11-18 15:27:31 UTC 
g_desktop_app_info_search() searches for desktop files that match the given string but does it in the current locale only; (in my memory) the Shell also used to match against entries in the C locale.

This changes g_desktop_app_info_search() to do the same thing.
Comment 1 Frederic Peters 2013-11-18 15:28:37 UTC 
Created attachment 260136 [details] [review]
make GDesktopAppInfo search use the C locale in addition of current locale
Comment 2 Allison Karlitskaya (desrt) 2013-11-18 15:51:36 UTC 
Why?

It's worth noting that the desktop index will fall back to other locales for search, but only if you explicitly list them in LANGUAGE=

If anything, I'd rather do it this way for the unindexed case as well..
Comment 3 Frederic Peters 2013-11-18 16:15:41 UTC 
> Why?

This patch was prompted by a translator pointing he was told not to duplicate English terms in his translated Keywords field, as the original English terms would also be searched.  When I looked at the code I noticed it was no longer the case and assumed it was lost when porting to the new g_desktop_app_info_search.

I'm all for giving clear instructions to translators, and perhaps that one was erroneous from day one.
Comment 4 Allison Karlitskaya (desrt) 2013-11-18 16:35:08 UTC 
(from IRC) I think we decided that what's actually missing is matching on the Exec= line...  it seems quite a lot of people are used to that.  Let's add that back in.
Comment 5 Philip Withnall 2017-09-13 12:12:16 UTC 
Actually, this was already done as bug #725023. Woohoo.

*** This bug has been marked as a duplicate of bug 725023 ***