After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712601 - gphoto backend returns wrong offset from seek
gphoto backend returns wrong offset from seek
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: gphoto backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-18 14:56 UTC by Ross Lagerwall
Modified: 2013-11-30 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gphoto2: Return the correct offset when seeking (1.11 KB, patch)
2013-11-18 14:58 UTC, Ross Lagerwall
accepted-commit_now Details | Review

Description Ross Lagerwall 2013-11-18 14:56:58 UTC
This breaks applications which try to seek to the end of the file and expect a non-zero return value.
Comment 1 Ross Lagerwall 2013-11-18 14:58:28 UTC
Created attachment 260129 [details] [review]
gphoto2: Return the correct offset when seeking
Comment 2 Ondrej Holy 2013-11-21 12:04:37 UTC
Review of attachment 260129 [details] [review]:

Looks good!
Comment 3 Ross Lagerwall 2013-11-30 13:59:17 UTC
Pushed to master as 159ef25cbe37176a9b2e1861fbf66a826097d19c and gnome-3-10 as d6ae1bce7ddd12d7ce7ae23141e1b4cd81aba562. Thanks!