After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712579 - Align to the right the label in thr run-dialog
Align to the right the label in thr run-dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 708220 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-11-18 12:13 UTC by Yosef Or Boczko
Modified: 2015-02-28 01:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot - run-dialog (95.16 KB, image/png)
2013-11-18 12:13 UTC, Yosef Or Boczko
  Details
runDialog: Align the label to the right in RTL (727 bytes, patch)
2013-11-18 12:14 UTC, Yosef Or Boczko
none Details | Review
runDialog: Explicitly set horizontal alignment (1.23 KB, patch)
2013-11-18 13:04 UTC, Florian Müllner
committed Details | Review
runDialog: Explicitly set horizontal alignment (1.71 KB, patch)
2013-12-11 22:30 UTC, Yosef Or Boczko
none Details | Review

Description Yosef Or Boczko 2013-11-18 12:13:13 UTC
Created attachment 260102 [details]
Screenshot - run-dialog

You can to see in the screenshot I attached,
the label in the run-dialog align to left instead
to right.
Comment 1 Yosef Or Boczko 2013-11-18 12:14:14 UTC
Created attachment 260103 [details] [review]
runDialog: Align the label to the right in RTL
Comment 2 Florian Müllner 2013-11-18 13:04:30 UTC
Created attachment 260108 [details] [review]
runDialog: Explicitly set horizontal alignment

When set to fill, the label will always end up left-aligned, which
is only correct in LTR locales. Set the alignment explicitly to
work in both RTL and LTR locales.


This is an alternative fix which does not require explicit handling of the locale. However we really should investigate why ClutterText is not handling this correctly itself.
Comment 3 Yosef Or Boczko 2013-11-18 13:13:38 UTC
Thanks, you patch realy fix the bug, without custom CSS.

Maybe to file a bug againt clutter for this?
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-12-11 20:40:36 UTC
Review of attachment 260108 [details] [review]:

OK.
Comment 5 Yosef Or Boczko 2013-12-11 22:30:30 UTC
Created attachment 264015 [details] [review]
runDialog: Explicitly set horizontal alignment
Comment 6 Florian Müllner 2013-12-16 17:29:57 UTC
Comment on attachment 260108 [details] [review]
runDialog: Explicitly set horizontal alignment

Attachment 260108 [details] pushed as fee2a07 - runDialog: Explicitly set horizontal alignment
Attachment 264015 [details] pushed as fee2a07 - runDialog: Explicitly set horizontal alignment
Comment 7 Florian Müllner 2015-02-28 01:23:57 UTC
*** Bug 708220 has been marked as a duplicate of this bug. ***