GNOME Bugzilla – Bug 712565
Fix compilation's warnings
Last modified: 2013-11-21 10:16:16 UTC
See the attached patch
Created attachment 260087 [details] [review] tasks: Fix return values
Created attachment 260088 [details] [review] demos: Fix GtkStock deprecated functions
Created attachment 260089 [details] [review] core: Replace deprecated GStaticMutex with GMutex
Created attachment 260090 [details] [review] core: Fix 'soup_gnome_features_2_26_get_type' is deprecated warning
Created attachment 260091 [details] [review] tests: Replace g_test_trap_fork with g_test_trap_subprocess when glib is greater than 2.38.0
Created attachment 260092 [details] [review] Update .gitignore
Review of attachment 260087 [details] [review]: Go for it.
Review of attachment 260088 [details] [review]: This doesn’t bump our GTK+ dependency, so please commit with the changes below. Thanks. ::: demos/scrapbook/scrapbook.c @@ +518,2 @@ /* OK button */ + button = gtk_button_new_with_label ("Ok"); The label should be capitalised and use an underscore: "_OK". @@ +589,3 @@ file_dialog = gtk_file_chooser_dialog_new ("Upload Photo", GTK_WINDOW (scrap_data->window), GTK_FILE_CHOOSER_ACTION_SAVE, + "Cancel", GTK_RESPONSE_CANCEL, + "Open", GTK_RESPONSE_ACCEPT, These should also use underscores.
Review of attachment 260089 [details] [review]: This doesn’t actually require a GLib version bump, so please commit immediately. Thanks!
Review of attachment 260090 [details] [review]: Does the default libsoup proxy resolver happen to be GProxyResolverGnome when in a GNOME environment? I assume so. Please amend the commit message to explain that the libsoup GNOME 2.26 feature was just the GNOME proxy resolver, which is now provided as a default GIO extension point. Then push it! Thanks.
Review of attachment 260090 [details] [review]: Actually, this means we can drop our libsoup-gnome dependency entirely. Please do so, and don’t forget to remove it from README. I guess the patch should be re-reviewed before pushing then.
Review of attachment 260091 [details] [review]: If this works and the tests still pass, please push.
Review of attachment 260092 [details] [review]: .gitignore should be being generated automatically by git.mk. Is that not working for you?
(In reply to comment #13) > Review of attachment 260092 [details] [review]: > > .gitignore should be being generated automatically by git.mk. Is that not > working for you? Ouch! It's generating a broken .gitignore I can see a lot of .defs and *.o not being ignored
(In reply to comment #14) > Ouch! It's generating a broken .gitignore > I can see a lot of .defs and *.o not being ignored Try updating git.mk from https://github.com/behdad/git.mk. If that doesn’t fix it, I guess you’ll have to debug git.mk itself. Might be something to do with subdir-objects.
Created attachment 260180 [details] [review] demos: Fix GtkStock deprecated functions
Attachment 260087 [details] pushed as 24f58b8 (libgdata 0.15+) Attachment 260089 [details] pushed as 52ebe1c (libgdata 0.15+) Attachment 260180 [details] pushed as e419233 (libgdata 0.15+)
(In reply to comment #15) > > Try updating git.mk from https://github.com/behdad/git.mk. If that doesn’t fix > it, I guess you’ll have to debug git.mk itself. Might be something to do with > subdir-objects. IIUC, you would need to have a Makefile per subfolder (as we have in evolution, for instance) to get git.mk working as expected. I'll ignore this for now :-)
Created attachment 260392 [details] [review] core: Fix 'soup_gnome_features_2_26_get_type' is deprecated warning GNOME 2.26 libsoup's feature was just the GNOME proxy resolver, which is now provided as default GIO extension point. More informations can be seen in: [0]: https://git.gnome.org/browse/libsoup/commit/?id=4ded0924fd82e006f31a8e9089fd297fac15eef9 [1]: https://bugzilla.gnome.org/show_bug.cgi?id=573685
Review of attachment 260392 [details] [review]: Great, thanks!
Comment on attachment 260392 [details] [review] core: Fix 'soup_gnome_features_2_26_get_type' is deprecated warning Attachment 260392 [details] pushed as 60e1cf1 (libgdata 0.15+)
Comment on attachment 260091 [details] [review] tests: Replace g_test_trap_fork with g_test_trap_subprocess when glib is greater than 2.38.0 This one wasn’t quite right; the new subprocess test needs to be declared using g_test_add(). Fixed and merged. commit d663cbff8a733d0296e81dc84c3ae6a307cb9b58 Author: Fabiano Fidêncio <fidencio@redhat.com> Date: Mon Nov 18 09:38:45 2013 +0100 tests: Replace g_test_trap_fork() with g_test_trap_subprocess() For GLib versions newer than 2.38.0. This continues to work for older versions, so the GLib dependency is not bumped. https://bugzilla.gnome.org/show_bug.cgi?id=712565 gdata/tests/client-login-authorizer.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-)