GNOME Bugzilla – Bug 712562
Fixes for the journal
Last modified: 2021-06-10 11:20:20 UTC
Together with two Clutter patches, this completely removes the calls to glReadPixels in gnome-shell. Whoa.
Created attachment 260075 [details] [review] framebuffer: Don't mark the clip dirty at mid scene
Created attachment 260076 [details] [review] framebuffer: Fix clip tracking in the unclipped case Leaving the clip bounds untouched means that it will retain the stale value of whatever it was when we last had a clip; reset it so that it contains the full framebuffer contents instead.
Attachment 260075 [details] pushed as 3eb63f6 - framebuffer: Don't mark the clip dirty at mid scene Attachment 260076 [details] pushed as 5c5715f - framebuffer: Fix clip tracking in the unclipped case
(In reply to comment #1) > Created an attachment (id=260075) [details] [review] > framebuffer: Don't mark the clip dirty at mid scene This patch doesn't look right because now nothing will ever set clear_clip_dirty = TRUE. Presumably that would mean that if a rectangle is drawn and then the journal is flushed before the framebuffer is read then it would think it could return the clear color even though it shouldn't. Perhaps a better approach would be to make a second version of _cogl_framebuffer_mark_mid_scene that doesn't set the clear_clip_dirty flag and call that from the journal instead. I've reverted the patch on the 1.18 branch as it was pushed without review and without first going into the master branch. If we make a new patch we can use the normal process of getting review and first applying it to master before cherry-picking it to the 1.18 branch.
(In reply to comment #2) > Created an attachment (id=260076) [details] [review] > framebuffer: Fix clip tracking in the unclipped case Note that Jasper has reverted this patch as well on the 1.18 branch.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of cogl, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a ticket at https://gitlab.gnome.org/GNOME/cogl/-/issues/ Thank you for your understanding and your help.