GNOME Bugzilla – Bug 712554
Right Ctrl+Alt fails to ungrab window
Last modified: 2016-03-31 13:22:07 UTC
When the mouse pointer is grabbed by the VM, Boxes displays a notice at the top of the screen: "press Ctrl+Alt to ungrab." However, this only works if the left Ctrl+Alt keys are used. The right Ctrl+Alt keys do not work as expected.
Its spice feature or issue afaict. It could be a feature since you might want to keep the right ctrl+alt for client/host. elmarco?
(In reply to comment #1) > Its spice feature or issue afaict. It could be a feature since you might want > to keep the right ctrl+alt for client/host. spice-gtk and gtk-vnc have same code for handling ungrab key accel. They both have the same "issue". There is a single combination, and left-ctrl right-ctrl are different there. It would make sense to update the message to say "left-ctrl + alt" Another possibility would be to reimplement ungrab by using gtk accels entirely, which doesn't differentiate left and right ctrl, afaik. This is how virt-viewer hotkeys are implemented, they do not make use of the spice-gtk/gtk-vnc accel code in fact, but plain gtk accels.
(In reply to comment #1) > Its spice feature or issue afaict. It could be a feature since you might want > to keep the right ctrl+alt for client/host. > > elmarco? I think the current behavior would be fine if the message is changed.
Created attachment 273803 [details] [review] Specify hint to make it clearer When grabbing the focus of a VM the hint says "press Ctrl+Alt keys to ungrab". Since only the left Ctrl key works it was decided in a discussion to change the hint and leave the functionality this way.
Review of attachment 273803 [details] [review]: 'Specify hint to make it clearer' What is 'it'? I think shorlog needs to be slightly more specific. How about "display-page: Specify exact CTRL key" ? ::: src/display-page.vala @@ +86,3 @@ string? hint = null; if (grabbed) + hint = _("(press Left-Ctrl+Alt keys to ungrab)"); Using '-' here doesn't seem good here together with '+'. How about just adding '(left) ' in front of 'Ctrl'. BTW, Shouldn't we be writing 'Ctrl+Alt' in all caps: CTRL+ALT?
Created attachment 273806 [details] [review] display-page: Specify exact CTRL key When grabbing the focus of a VM the hint says "press Ctrl+Alt keys to ungrab". Since only the left Ctrl key works it was decided in a discussion to change the hint and leave the functionality this way.
Review of attachment 273806 [details] [review]: I used the [] brackets since the whole hint appears in brackets. I like (a hint with a [little] addition) much better than (a hint with a (little) addition).
Thanks for working on this. (In reply to comment #5) > Using '-' here doesn't seem good here together with '+'. How about just adding > '(left) ' in front of 'Ctrl'. BTW, Shouldn't we be writing 'Ctrl+Alt' in all > caps: CTRL+ALT? No, these are consistently lowercase in GNOME applications: you can check any menu to see the accelerators next to a menu item, or look in Settings -> System -> Keyboard -> Shortcuts.
(In reply to comment #8) > Thanks for working on this. > > (In reply to comment #5) > > Using '-' here doesn't seem good here together with '+'. How about just adding > > '(left) ' in front of 'Ctrl'. BTW, Shouldn't we be writing 'Ctrl+Alt' in all > > caps: CTRL+ALT? > > No, these are consistently lowercase in GNOME applications: you can check any > menu to see the accelerators next to a menu item, or look in Settings -> System > -> Keyboard -> Shortcuts. I agree. And it looks better too IMHO. Uploading the new patch in a few moments.
Created attachment 273816 [details] [review] display-page: Specify exact Ctrl key When grabbing the focus of a VM the hint says "press Ctrl+Alt keys to ungrab". Since only the left Ctrl key works it was decided in a discussion to change the hint and leave the functionality this way.
Review of attachment 273816 [details] [review]: ack
Attachment 273816 [details] pushed as ab6cc04 - display-page: Specify exact Ctrl key