GNOME Bugzilla – Bug 712538
srcdir != builddir fixes to build in Continuous
Last modified: 2014-01-04 16:13:59 UTC
I'd like to add Seahorse to the Continuous manifest.
Created attachment 260037 [details] [review] common: Work around vala srcdir != builddir from git issues gnome-continuous uses srcdir != builddir *from git*. This differs from tarballs where generated source lives in $(srcdir). Anyways, vala's AM_PROG_VALAC generates some makefile rules that do "cd $(srcdir) && valac ...". See: https://bugzilla.gnome.org/show_bug.cgi?id=694153 The problem is this actively breaks the $(srcdir) and $(builddir) automake macros when doing srcdir != builddir from git. We can work around it this way.
Created attachment 260038 [details] [review] build: Update includes to work with srcdir != builddir from git seahorse-common.h is in $(builddir) when doing srcdir != builddir from git.
Review of attachment 260037 [details] [review]: ::: common/Makefile.am @@ +33,3 @@ --use-header \ + --header=$(shell cd $(builddir) && pwd)/seahorse-internal.h \ + --vapidir=$(shell cd $(srcdir) && pwd) \ Why can't we use $(abs_builddir) and $(abs_srcdir)?
Comment on attachment 260038 [details] [review] build: Update includes to work with srcdir != builddir from git Pushed as 6a70791e8033fbc37f95beb1673d31a70eaf9a4a
Created attachment 260386 [details] [review] common: Work around vala srcdir != builddir from git issues Now using $(abs_) variants.
Attachment 260386 [details] pushed as a8ab0f0 - common: Work around vala srcdir != builddir from git issues