After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712535 - Documentation fixes for the Telepathy classes
Documentation fixes for the Telepathy classes
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Telepathy
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-17 11:07 UTC by Emanuele Aina
Modified: 2013-11-22 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathy: Documentation fixes (5.78 KB, patch)
2013-11-17 11:07 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-11-17 11:07:30 UTC 
• Wire up the new classes to gtk-doc
• Use consistent naming for the provider_[name|type] parameter in
  goa_provider_factory_get_provider()
• Expand a bit on the provider_name meaning
Comment 1 Emanuele Aina 2013-11-17 11:07:32 UTC 
Created attachment 260033 [details] [review]
telepathy: Documentation fixes

• Wire up the new classes to gtk-doc
• Use consistent naming for the provider_[name|type] parameter in
  goa_provider_factory_get_provider()
• Expand a bit on the provider_name meaning
Comment 2 Debarshi Ray 2013-11-22 15:40:00 UTC 
Review of attachment 260033 [details] [review]:

Committed. Thanks for the patch.

These classes are not really exposed to applications, so in some sense their documentation does not need to be exported via gtk-doc. However, since we are exposing the other providers via gtk-doc, why not? Maybe in future we can just leave them documented in the code and not export them via gtk-doc. We will see.