After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712517 - renderer: implement PlaybackStorageMedium variable
renderer: implement PlaybackStorageMedium variable
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-renderer
unspecified
Other All
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-16 17:51 UTC by Jussi Kukkonen
Modified: 2013-11-17 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
renderer: implement PlaybackStorageMedium variable (2.81 KB, patch)
2013-11-16 17:51 UTC, Jussi Kukkonen 		committed Details | Review

Description Jussi Kukkonen 2013-11-16 17:51:40 UTC 
PlaybackStorageMedium should return either NONE or the storage medium
of the current AVTransportURI. I noticed we don't do this from looking
at DLNA CTT case 7.3.104.3: bug 256067 fixes that one half way -- the
LastChange query still returns NOT_IMPLEMENTED for it. This patch
fixes both PlaybackStorageMedium and LastChange value of
PossiblePlaybackStorageMedium.

A Rygel.MediaPlayer should be able to define these values (with
whatever weird mediums it happens to support), but I think this
generic solution is good enough until we have at least one
MediaPlayer that actually wants to do something special.
Comment 1 Jussi Kukkonen 2013-11-16 17:51:42 UTC 
Created attachment 260016 [details] [review]
renderer: implement PlaybackStorageMedium variable

PlaybackStorageMedium should be "NETWORK" when AVTransportURI
refers to a resource received from the UPnP network. It should be
NONE if AVTransportURI is not set.

Also fix the LastChange value of PossiblePlaybackStorageMedium.
Comment 2 Jussi Kukkonen 2013-11-16 17:54:59 UTC 
(In reply to comment #0)
> I noticed we don't do this from looking
> at DLNA CTT case 7.3.104.3: bug 256067 fixes that one half way

Er, that should have been bug 677405.
Comment 3 Jens Georg 2013-11-17 13:14:24 UTC 
Review of attachment 260016 [details] [review]:

Good catch, thanks
Comment 4 Jens Georg 2013-11-17 17:08:27 UTC 
Attachment 260016 [details] pushed as 01de181 - renderer: implement PlaybackStorageMedium variable