After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712398 - build: Actually install defs.py
build: Actually install defs.py
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-15 21:17 UTC by Colin Walters
Modified: 2013-11-17 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Actually install defs.py (1.07 KB, patch)
2013-11-15 21:17 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2013-11-15 21:17:11 UTC 
Otherwise we fail to set PKGDATADIR, which causes us to fail to load
shell.css, which causes us to fail to start.

The correct way to do this though, in my opinion, is to *not* pollute
the global Python namespace with this application's internals.  We
don't expect other Python programs to "import gtweak".

The way gobject-introspection does this is to install the Python code
to $(pkglibdir), and substitute in the wrapper script to add that to
sys.path.
Comment 1 Colin Walters 2013-11-15 21:17:13 UTC 
Created attachment 259949 [details] [review]
build: Actually install defs.py
Comment 2 John Stowers 2013-11-17 10:50:09 UTC 
Hmm, I wonder how this previously worked?

Anyway, I take your point about installing stuff in pkglibdir. I will take a look at how gi does it.
Comment 3 John Stowers 2013-11-17 10:51:07 UTC 
Attachment 259949 [details] pushed as e44f95b - build: Actually install defs.py