After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712393 - gobject: Box GMappedFile
gobject: Box GMappedFile
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-11-15 19:49 UTC by Ray Strode [halfline]
Modified: 2013-11-15 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gobject: Box GMappedFile (6.91 KB, patch)
2013-11-15 19:49 UTC, Ray Strode [halfline]
none Details | Review
gobject: Box GMappedFile (6.91 KB, patch)
2013-11-15 19:56 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2013-11-15 19:49:05 UTC
GMappedFile is current unintrospectable, because it's not a registered
box type.  It already has reference counting functions, so there's
little reason not to box it.

This commit adds GMappedFile to the hoard of other boxes types handled
by gboxed.c
Comment 1 Ray Strode [halfline] 2013-11-15 19:49:07 UTC
Created attachment 259943 [details] [review]
gobject: Box GMappedFile
Comment 2 Ray Strode [halfline] 2013-11-15 19:54:36 UTC
Review of attachment 259943 [details] [review]:

::: gobject/glib-types.h
@@ +260,3 @@
+ * The #GType for a boxed type holding a #GMappedFile.
+ *
+ * Since: 2.32

this should say 2.40 obviously
Comment 3 Ray Strode [halfline] 2013-11-15 19:56:49 UTC
Created attachment 259945 [details] [review]
gobject: Box GMappedFile

GMappedFile is current unintrospectable, because it's not a registered
box type.  It already has reference counting functions, so there's
little reason not to box it.

This commit adds GMappedFile to the hoard of other boxes types handled
by gboxed.c
Comment 4 Ray Strode [halfline] 2013-11-15 20:57:02 UTC
Attachment 259945 [details] pushed as cfc8215 - gobject: Box GMappedFile

(pushed after talking with mclasen about it)