GNOME Bugzilla – Bug 712382
Compilation warnings
Last modified: 2018-05-04 10:23:14 UTC
There is several compilation warnings which could be fixed. gdaemonfileenumerator.c: In function 'add_timeout_for_context': gdaemonfileenumerator.c:112:9: warning: unused variable 'id' [-Wunused-variable] guint id; ^ gvfsbackendsftp.c: In function ‘try_seek_on_read’: gvfsbackendsftp.c:2575:7: warning: enumeration value ‘G_SEEK_END’ not handled in switch [-Wswitch] switch (job->seek_type) ^ gvfsbackendsftp.c: In function ‘try_seek_on_write’: gvfsbackendsftp.c:3706:7: warning: enumeration value ‘G_SEEK_END’ not handled in switch [-Wswitch] switch (job->seek_type) ^ gvfsbackendafp.c: In function ‘try_seek_on_read’: gvfsbackendafp.c:823:5: warning: enumeration value ‘G_SEEK_END’ not handled in switch [-Wswitch] switch (job->seek_type)
Created attachment 259923 [details] [review] gdaemonfile fix
Created attachment 259924 [details] [review] sftp fix
Created attachment 259925 [details] [review] afp fix
Review of attachment 259923 [details] [review]: Looks good!
Created attachment 260073 [details] gcc 4.8.2 warnings FWIW, these are the warnings I get from gcc 4.8.2 (Fedora 20).
Created attachment 260074 [details] clang 3.3 warnings These are the warnings I get with clang 3.3 (Fedora 20).
Review of attachment 259924 [details] [review]: Looks good!
Review of attachment 259925 [details] [review]: Looks good!
Created attachment 260081 [details] [review] fuse: Remove duplicate assignment
Created attachment 260082 [details] [review] udisks2: Define SECRET_API_SUBJECT_TO_CHANGE to silence warning
Created attachment 260083 [details] [review] udisks2: Compile function only if we have udisks >= 2.0.90
Created attachment 260084 [details] [review] Make file-local functions static This silences some warnings.
Created attachment 260085 [details] [review] udisks2: Initialize variables to prevent them being used uninitialized
Created attachment 260086 [details] [review] client: Use the correct enumeration constant
Comment on attachment 259923 [details] [review] gdaemonfile fix commit 5110e2744b90b9ea62e99fc2405e77ed81efecea
Comment on attachment 259924 [details] [review] sftp fix commit 53933e21316db15d70b540501af716860c0ff055
Comment on attachment 259925 [details] [review] afp fix commit 65216faae97bfce29006fbd479feed6fc37cf342
The patches looks good, thanks for them, feel free to commit :-) (In reply to comment #5) > Created an attachment (id=260073) [details] > gcc 4.8.2 warnings > > FWIW, these are the warnings I get from gcc 4.8.2 (Fedora 20). Looks like new version is more strict, so thanks for fixing those warnings... (In reply to comment #6) > Created an attachment (id=260074) [details] > clang 3.3 warnings > > These are the warnings I get with clang 3.3 (Fedora 20). Cool, looks like -Wcast-align is disabled by default in gcc in contrast to clang, would be nice to check all of those warnings and fix them if possible, however gcc is default, so we don't care about warnings if everything is correct.
Created attachment 301789 [details] [review] build: Rename deprecated g_unix_mount_monitor_new g_unix_mount_monitor_new is deprecated now. It was renamed to g_unix_mount_monitor_get, because it is singleton. See Bug 742599. Bump the glib version accordingly.
Review of attachment 301789 [details] [review]: Looks good!
Comment on attachment 301789 [details] [review] build: Rename deprecated g_unix_mount_monitor_new commit 463e5b10539bc985efc30ea7da0bf045654ef75b
This is an old bug and I don't see currently any build warnings, let's close as fixed...