After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712361 - m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1
m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-15 11:56 UTC by Philip Withnall
Modified: 2013-11-15 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1 (1.28 KB, patch)
2013-11-15 11:56 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2013-11-15 11:56:26 UTC
The AM_PROG_VALAC macro is currently being highlighted incorrectly if used with three parameters instead of just one.
Comment 1 Philip Withnall 2013-11-15 11:56:27 UTC
Created attachment 259867 [details] [review]
m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1

The AM_PROG_VALAC automake macro has been able to take 3 parameters (1
mandatory, 2 optional) for a while, just like AM_PATH_PYTHON.

See:
http://www.gnu.org/software/automake/manual/html_node/Vala-Support.html#index-AM_005fPROG_005fVALAC
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-11-15 11:58:33 UTC
Review of attachment 259867 [details] [review]:

If you tested it and works fine go ahead.
Comment 3 Philip Withnall 2013-11-15 12:04:09 UTC
Comment on attachment 259867 [details] [review]
m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1

commit 35a95659f83c41835829cf1eb19719e174902460
Author: Philip Withnall <philip.withnall@collabora.co.uk>
Date:   Fri Nov 15 11:53:52 2013 +0000

    m4: Fix AM_PROG_VALAC macro to take 3 parameters instead of 1
    
    The AM_PROG_VALAC automake macro has been able to take 3 parameters (1
    mandatory, 2 optional) for a while, just like AM_PATH_PYTHON.
    
    See:
    http://www.gnu.org/software/automake/manual/html_node/Vala-Support.html#index-AM_005fPROG_005fVALAC
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712361

 data/language-specs/m4.lang | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)