GNOME Bugzilla – Bug 712323
Substantially expand EVCard documentation
Last modified: 2013-11-23 13:53:20 UTC
I got bored of looking at the implementations of various EVCard methods to work out what on earth they’re meant to do, so I wrote some documentation. Patches coming! There are two patches here which make functional fixes as well. These pass the test suite, but should probably be scrutinised well.
Created attachment 259833 [details] [review] e-vcard: Fix a minor memory leak for multi-valued parameters
Created attachment 259834 [details] [review] e-vcard: Substantially expand EVCard documentation
Created attachment 259835 [details] [review] e-vcard: Fix case sensitivity of string comparisons The rest of the code (and the specification) uniformly uses case-insensitive comparisons of attribute names and parameter values.
Wow, these look awesome. Thanks a ton! I'll review these in more detail tomorrow or by Monday at the latest.
Documentation is excellent. Thanks again for this! Committed for E-D-S 3.11.3: https://git.gnome.org/browse/evolution-data-server/commit/?id=26eb7865458c59d38c82efb853611f9e7250cb3d https://git.gnome.org/browse/evolution-data-server/commit/?id=88240da1b6e1c39801c4de19d91e79dee205d842 https://git.gnome.org/browse/evolution-data-server/commit/?id=f508b03403e89d4484892b3b2a2dd5be1ac534ca And backported for E-D-S 3.10.3: https://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-10&id=2521cd84e6b3ef4031da765d15a44a93d3e770d0 https://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-10&id=eb8a7ada6bb432d25f62ed11cf7b9cd1040d6c85 https://git.gnome.org/browse/evolution-data-server/commit/?h=gnome-3-10&id=5b6a9a72ee461c8ff727d620ccfdd6b0de35c1f6