After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712322 - input-device-xi2: Calculate the correct state for button events
input-device-xi2: Calculate the correct state for button events
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-14 18:03 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-11-14 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
input-device-xi2: Calculate the correct state for button events (2.81 KB, patch)
2013-11-14 18:03 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-11-14 18:03:28 UTC
The state that the X server sends for button events, by specification,
contains the button state before the event. We need to synthesize in
the result of the event in order to determine what the current button
state is.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-11-14 18:03:30 UTC
Created attachment 259832 [details] [review]
input-device-xi2: Calculate the correct state for button events
Comment 2 Emmanuele Bassi (:ebassi) 2013-11-14 18:36:11 UTC
Review of attachment 259832 [details] [review]:

looks okay. please commit to both the clutter-1.16 and the clutter-1.18 branches.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-11-14 19:34:09 UTC
Attachment 259832 [details] pushed as c2b0b9a - input-device-xi2: Calculate the correct state for button events