After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712310 - Should update language menus when audio tags are changed
Should update language menus when audio tags are changed
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks:
 
 
Reported: 2013-11-14 15:52 UTC by Guillaume Desmottes
Modified: 2014-01-27 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
update sublangs menus when meta data are updated (858 bytes, patch)
2013-11-14 15:54 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2013-11-14 15:52:38 UTC 
At the moment, the languages and subtitles menus are updated only when the "channels-change" signal is fired. We need to update them when the metadata are updated to fix the following scenario:

- Totem sets the "languages" menu. There is no GST_TAG_LANGUAGE_CODE pushed yet so it uses the default labels ("Audio Track #1", etc).
- GStreamers pushes the GST_TAG_LANGUAGE_CODE to some audio pads
- GstPlaybin fires "audio-tags-changed"
- Totem catches the signal but doesn't update the languages menu, leaving the default labels.
Comment 1 Guillaume Desmottes 2013-11-14 15:54:10 UTC 
Created attachment 259817 [details] [review]
update sublangs menus when meta data are updated

The meta data can contains the language of the audio streams
(GST_TAG_LANGUAGE_CODE) so we may have to update the menu to reflect the
change.
Comment 2 Bastien Nocera 2014-01-26 00:10:25 UTC 
Review of attachment 259817 [details] [review]:

Looks good to commit to master and gnome-3-10.
Comment 3 Guillaume Desmottes 2014-01-27 09:11:44 UTC 
Merged to both branches. thanks!

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.