GNOME Bugzilla – Bug 712287
Use GL_TEXTURE_2D (npot) instead of GL_TEXTURE_RECTANGLE
Last modified: 2013-11-26 11:17:33 UTC
In my quest for vaapi integration. I came across the following problem. We create our textures (in Desktop GL) with GL_TEXTURE_RECTANGLE, vaapi attempts to bind our texture to GL_TEXTURE_2D which throws a GL_INVALID_OPERATION error and as thus, no video. By moving exclusively to GL_TEXTURE_2D and the npot extension we also remove a difference between the Desktop GL and GLES2 code.
Created attachment 259857 [details] [review] use GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE
+1 :)
It would be nice to have the rationale in the commit message as well :)
Created attachment 259861 [details] [review] use GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE
commit fffdcbdd3dde437e10cf6e1b5e40c6958d41e6c1 Author: Matthew Waters <ystreet00@gmail.com> Date: Fri Nov 15 18:28:49 2013 +1100 gl: Use GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE We create our textures (in Desktop GL) with GL_TEXTURE_RECTANGLE, vaapi attempts to bind our texture to GL_TEXTURE_2D which throws a GL_INVALID_OPERATION error and as thus, no video. Also, by moving exclusively to GL_TEXTURE_2D and the npot extension we also remove a difference between the Desktop GL and GLES2 code. https://bugzilla.gnome.org/show_bug.cgi?id=712287