After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712282 - Wayland backend fails to compile with GStreamer 0.10
Wayland backend fails to compile with GStreamer 0.10
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
0.5.6
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-14 10:58 UTC by Ross Burton
Modified: 2013-11-22 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: link libgstvaapi-wayland against videoutils (981 bytes, patch)
2013-11-14 11:01 UTC, Ross Burton
none Details | Review

Description Ross Burton 2013-11-14 10:58:19 UTC
Like this:

../gst-libs/gst/vaapi/.libs/libgstvaapi-wayland-0.10.so: undefined
reference to `gst_video_info_set_format'
Comment 1 Ross Burton 2013-11-14 11:01:54 UTC
Created attachment 259795 [details] [review]
build: link libgstvaapi-wayland against videoutils

This library is using symbols that don't exist in GStreamer 0.10 so it needs to
link to gstvaapi-videoutils.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Comment 2 Gwenole Beauchesne 2013-11-14 11:54:26 UTC
OK, I will move the lib down before the NULL clause so that to keep some kind of alignment. :)
Comment 3 Dominique Leuenberger 2013-11-18 21:04:17 UTC
It also fails to build if the wayland headers are not to be found in /usr/inluce directly (on openSUSE, they live in /usr/include/wayland for example).

I added this patch to correct this:
###
diff -ur gstreamer-vaapi-0.5.4/gst/vaapi/Makefile.am gstreamer-vaapi-0.5.4.patched/gst/vaapi/Makefile.am
--- gstreamer-vaapi-0.5.4/gst/vaapi/Makefile.am 2013-05-28 11:06:38.000000000 +0200
+++ gstreamer-vaapi-0.5.4.patched/gst/vaapi/Makefile.am 2013-11-18 21:57:16.979471403 +0100
@@ -27,6 +27,9 @@
 if USE_WAYLAND
 libgstvaapi_LIBS += \
        $(top_builddir)/gst-libs/gst/vaapi/libgstvaapi-wayland-$(GST_API_VERSION).la
+libgstvaapi_CFLAGS += \
+       $(WAYLAND_CFLAGS) \
+       $(NULL)
 endif
 
 libgstvaapi_source_c = \
###
Comment 4 Gwenole Beauchesne 2013-11-22 10:33:27 UTC
commit e713d43379d9ca1d543bb37f6854f4ef7a03824b
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Fri Nov 22 11:28:09 2013 +0100

    build: fix for Wayland headers not in standard include dirs.
    
    Fix build when Wayland headers don't live in plain system include dirs
    like /usr/include but rather in /usr/include/wayland for instance.
    
    Original patch written by Dominique Leuenberger <dimstar@opensuse.org>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712282

commit bc8a87d8bb9996d32cd68784fb8a0c5e98210639
Author: Ross Burton <ross.burton@intel.com>
Date:   Thu Nov 14 10:58:37 2013 +0000

    build: link libgstvaapi-wayland against videoutils.
    
    This library is using symbols that don't exist in GStreamer 0.10 so
    it needs to link to built-in implementation (libgstvaapi-videoutils).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712282
    
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>