After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712249 - Show backlogs
Show backlogs
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-13 21:02 UTC by Florian Müllner
Modified: 2013-11-13 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
chatView: Change low-level insert methods to take an iter (3.58 KB, patch)
2013-11-13 21:03 UTC, Florian Müllner
committed Details | Review
chatView: Split _insertMessage() (10.03 KB, patch)
2013-11-13 21:03 UTC, Florian Müllner
committed Details | Review
chatView: Insert backlogs on startup (4.09 KB, patch)
2013-11-13 21:03 UTC, Florian Müllner
committed Details | Review
chatView: Fetch more logs when scrolling past the top (3.27 KB, patch)
2013-11-13 21:03 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-11-13 21:02:58 UTC
See patches.
Comment 1 Florian Müllner 2013-11-13 21:03:01 UTC
Created attachment 259755 [details] [review]
chatView: Change low-level insert methods to take an iter

We will start displaying logged messages from previous conversations
in the chat log soon. Those messages should appear at the top of the
log rather than the bottom as live messages, so make the low-level
insertion methods a bit more flexible.
Comment 2 Florian Müllner 2013-11-13 21:03:05 UTC
Created attachment 259756 [details] [review]
chatView: Split _insertMessage()

We will start to include backlogs, which will use the same format as
normal messages, but are not stored as TpMessages. In order to share
the existing code, split _insertMessage() into a generic method and
_insertTpMessage() which drives it for TpMessages.
Comment 3 Florian Müllner 2013-11-13 21:03:09 UTC
Created attachment 259757 [details] [review]
chatView: Insert backlogs on startup

Backlogs from previous conversations can provide useful context, so
we should include them. Fetch a reasonable amount on startup to fill
the chat log, we will add a way to request more logs soon.
Comment 4 Florian Müllner 2013-11-13 21:03:13 UTC
Created attachment 259758 [details] [review]
chatView: Fetch more logs when scrolling past the top

The backlog we fetch on startup may not be enough, so allow users
to request more history by scrolling past the top.
Comment 5 Florian Müllner 2013-11-13 21:05:38 UTC
Attachment 259755 [details] pushed as af0495f - chatView: Change low-level insert methods to take an iter
Attachment 259756 [details] pushed as 53b53d6 - chatView: Split _insertMessage()
Attachment 259757 [details] pushed as 53c4b46 - chatView: Insert backlogs on startup
Attachment 259758 [details] pushed as 3c281b9 - chatView: Fetch more logs when scrolling past the top