After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712187 - Decode 64 bit integers also
Decode 64 bit integers also
Status: RESOLVED FIXED
Product: ghex
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GHex maintainers
GHex maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-12 23:57 UTC by Brendan Long
Modified: 2015-08-28 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add 64-bit integer decoding (5.54 KB, patch)
2013-11-12 23:57 UTC, Brendan Long 		none Details | Review
Patch to add 64-bit integer decoding (5.55 KB, patch)
2013-11-13 01:41 UTC, Brendan Long 		committed Details | Review

Description Brendan Long 2013-11-12 23:57:31 UTC 
Created attachment 259703 [details] [review]
Patch to add 64-bit integer decoding

I needed a hex editor to read Matroska files, and they can contain 64-bit integers. Since 64-bit is probably going to become more common in the future, it would be nice if GHex supported this.
Comment 1 Brendan Long 2013-11-13 00:19:58 UTC 
Actually my patch may be doing the conversion wrong. I'm still investigating.
Comment 2 Brendan Long 2013-11-13 01:41:33 UTC 
Created attachment 259707 [details] [review]
Patch to add 64-bit integer decoding

The last version was broken because pow2 was overflowing. Interestingly, it caused the output to match one of the programs I'm testing, which means I know what the bug is there now too.

The version of the patch works for me.
Comment 3 Kalev Lember 2015-08-28 21:50:03 UTC 
That's a great patch, thanks! Sorry for the delay.

Pushed to master as https://git.gnome.org/browse/ghex/commit/?id=f56cbdb6bf136c914adb4f93adda440d6becd7a1