After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712153 - gst-plugins-bad should not be needed
gst-plugins-bad should not be needed
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.10.x
Other All
: Normal trivial
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-12 14:42 UTC by Antoine Jacoutot
Modified: 2013-11-12 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
do not check for gst-plugins-bad (773 bytes, patch)
2013-11-12 14:42 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2013-11-12 14:42:16 UTC 
Created attachment 259666 [details] [review]
do not check for gst-plugins-bad

IIRC this commit correctly:
835e9ccf5e02f294ebf05e459e4ddcc95c497f26
Then gst-plugins-bad is not needed anymore.

Ok to push this?
Comment 1 Bastien Nocera 2013-11-12 14:43:56 UTC 
Did you actually check that the backend didn't use any -bad plugins?
Comment 2 Antoine Jacoutot 2013-11-12 15:02:00 UTC 
(In reply to comment #1)
> Did you actually check that the backend didn't use any -bad plugins?

As a totem developer I suppose you should know better than I do.
The dependency was added when soundpitch support was added; then scaletempo  replaced it (but was still part of -bad) and some time ago scaletempo was moved from gst-plugins-bad to gst-plugins-good...

But as I mentioned already you should know better than I do.
Comment 3 Bastien Nocera 2013-11-12 16:26:31 UTC 
Review of attachment 259666 [details] [review]:

Let's remove the check in master and gnome-3-10 and see if anyone complains.
Comment 4 Antoine Jacoutot 2013-11-12 17:01:43 UTC 
> Let's remove the check in master and gnome-3-10 and see if anyone complains.

Thank you Bastien. It's in now... you are entitled to send the rantings to me ;-)