After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712150 - Add appdata-tools to core-deps-3.12 moduleset
Add appdata-tools to core-deps-3.12 moduleset
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-11-12 13:49 UTC by David King
Modified: 2013-11-12 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add appdata-tools to core-deps moduleset (1.15 KB, patch)
2013-11-12 13:51 UTC, David King
none Details | Review
use tarball release (1.43 KB, patch)
2013-11-12 14:12 UTC, David King
committed Details | Review

Description David King 2013-11-12 13:49:56 UTC
Now that appdata-tools has an M4 macro for handling validation and installation of AppData files:

https://github.com/hughsie/appdata-tools/commit/7432eaf5b64e7751cfa403359d00a507f53a480b

it would be great to be able to depend on it in GNOME projects. I have a branch ready to go for gnome-logs:

https://git.gnome.org/browse/gnome-logs/commit/?h=wip/appdata

I am not sure if core-deps is the right place, maybe sysdeps is a better fit, which would match with desktop-file-utils.
Comment 1 David King 2013-11-12 13:51:33 UTC
Created attachment 259663 [details] [review]
add appdata-tools to core-deps moduleset
Comment 2 Frederic Peters 2013-11-12 13:57:30 UTC
core-deps is nice for now, sysdeps is for things that are commonly available in distributions.

Under the old "external deps" rule, it would be best if it was served as a tarball. Alternatively could you mention the tarball location, so the next person handling a gnome release (that do require tarballs) won't have to hunt them?
Comment 3 David King 2013-11-12 14:12:12 UTC
Created attachment 259664 [details] [review]
use tarball release

Thanks for the comments, and the explanation about sysdeps.

I updated the patch to use the latest tarball, which has the AppData M4 macro.
Comment 4 Frederic Peters 2013-11-12 14:15:41 UTC
Comment on attachment 259664 [details] [review]
use tarball release

Great, go for it.
Comment 5 David King 2013-11-12 14:21:22 UTC
Comment on attachment 259664 [details] [review]
use tarball release

Thanks, pushed to master as b28368e04946b63f59e4dcdedb620b224f378714.