After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712131 - gst-rtsp-server: allow auth with certificate and no basic authentication
gst-rtsp-server: allow auth with certificate and no basic authentication
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-12 01:00 UTC by Aleix Conchillo Flaqué
Modified: 2013-11-13 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
do not perform checks if no basic auth added (2.32 KB, patch)
2013-11-12 01:06 UTC, Aleix Conchillo Flaqué
rejected Details | Review

Description Aleix Conchillo Flaqué 2013-11-12 01:00:14 UTC
Currently, when an auth is set to the server a basic auth needs to be added if you want to enable TLS support. So, the URI will always look like:

  rtsps://user:password@host:port/path

It would be great that this was supported as well:

  rtsps://host:port/path
Comment 1 Aleix Conchillo Flaqué 2013-11-12 01:06:53 UTC
Created attachment 259629 [details] [review]
do not perform checks if no basic auth added

We check if we have added any basic auth, if not we only perform the check connect to set the TLS certificate.
Comment 2 Wim Taymans 2013-11-12 10:12:02 UTC
This is not right. The idea is to use gst_rtsp_auth_set_default_token() to list the authorizations of unauthenticated clients.
Comment 3 Aleix Conchillo Flaqué 2013-11-12 14:32:54 UTC
(In reply to comment #2)
> This is not right. The idea is to use gst_rtsp_auth_set_default_token() to list
> the authorizations of unauthenticated clients.

That's what I expected ;-). I tried that with an empty token but didn't work. I'll take a closer look today, sorry, I was in a hurry yesterday.
Comment 4 Aleix Conchillo Flaqué 2013-11-12 22:33:10 UTC
OK, marking as INVALID. We can certainly do this with the default token. I just wanted something that required less typing.

Now we need:

  token =
      gst_rtsp_token_new (GST_RTSP_TOKEN_MEDIA_FACTORY_ROLE, G_TYPE_STRING,
      "all", NULL);

  gst_rtsp_auth_set_default_token (auth, token);

  gst_rtsp_permissions_add_role (permissions, "all",
      GST_RTSP_PERM_MEDIA_FACTORY_ACCESS, G_TYPE_BOOLEAN, TRUE,
      GST_RTSP_PERM_MEDIA_FACTORY_CONSTRUCT, G_TYPE_BOOLEAN, TRUE, NULL);

   gst_rtsp_media_factory_set_permissions (factory, permissions);
Comment 5 Wim Taymans 2013-11-13 08:55:08 UTC
I agree that it is a lot of typing for nothing. I was thinking about a method on GstRTSPAuth to get the 'default' token or maybe to make a method to allow everything as if no default token was configured.