After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711854 - unread messages not obvious
unread messages not obvious
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-11 17:01 UTC by Matthias Clasen
Modified: 2015-04-23 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
theme: don't fade out channels on backdrop (1.05 KB, patch)
2015-04-16 13:57 UTC, Jakub Steiner
committed Details | Review
ui: Use non-backdrop colors in room list (1.61 KB, patch)
2015-04-23 14:52 UTC, Florian Müllner
committed Details | Review

Description Matthias Clasen 2013-11-11 17:01:16 UTC
When a channel has unread messages, the label in the sidebar seems to turn from light gray to slightly darker gray - that is not at all visible. May I suggest good old bold ?
Comment 1 Florian Müllner 2013-11-11 17:13:28 UTC
(In reply to comment #0)
> May I suggest good old bold ?

That's used to indicate highlighted messages atm.
Comment 2 Jakub Steiner 2013-11-11 17:27:59 UTC
The reason why the contrast between idle and active channel isn't so strong is that we wanted to avoid Polari looking all insensitive with inactive channels. 

I don't think indicating active channels stronger is that much of a good thing. Unless there is a danger of missing direct communication, it's perfectly fine to let the stream of information go by. From where I stand, I think we strike a good balance.
Comment 3 Matthias Clasen 2013-11-12 04:35:02 UTC
I'd love to let it all go by, but I can only let one stream go by at a time...
Comment 4 Jakub Steiner 2013-11-12 11:14:30 UTC
"Let go by" as in, it's fine if you're not constantly tapped on the shoulder "Hey, there's something going on elsewhere. you should check it out. You're missing out!"

There is a balance to strike between allowing to see conversations that aren't specifically directed at me and distracting/feeding the OCD in me. If we go bold or colored for this, from my point of view we throw this balance off towards OCD.
Comment 5 Florian Müllner 2014-02-28 06:15:12 UTC
(In reply to comment #2)
> The reason why the contrast between idle and active channel isn't so strong is
> that we wanted to avoid Polari looking all insensitive with inactive channels.

Personally I quite like what we have for focused windows, but the backdrop state is hardly working at all for me - can we tweak that a bit?
Comment 6 Vincent Untz 2015-04-16 09:46:27 UTC
(In reply to Jakub Steiner from comment #4)
> "Let go by" as in, it's fine if you're not constantly tapped on the shoulder
> "Hey, there's something going on elsewhere. you should check it out. You're
> missing out!"

Well, it depends. For some channels, I actually really want to read everything that's going on because, say, I'm the maintainer of that project and the traffic on this channel is not so important. Some other channels might be too noisy and it makes no sense to try to follow these all the time.

But I agree with Matthias that the current way is not optimal: right now, I have to take 2s to stop and double-check that the channel was not active because the difference between the two greys is way too small.
Comment 7 Jakub Steiner 2015-04-16 13:57:11 UTC
Created attachment 301731 [details] [review]
theme: don't fade out channels on backdrop

- headers/titles are enough
Comment 8 Florian Müllner 2015-04-16 13:59:53 UTC
Review of attachment 301731 [details] [review]:

LGTM
Comment 9 Jakub Steiner 2015-04-16 15:01:57 UTC
Attachment 301731 [details] pushed as aa099db - theme: don't fade out channels on backdrop
Comment 10 Florian Müllner 2015-04-23 14:52:39 UTC
Meh, I should not blindly review patches :-(
Comment 11 Florian Müllner 2015-04-23 14:52:59 UTC
Created attachment 302221 [details] [review]
ui: Use non-backdrop colors in room list

The intention of commit aa099dbfd41 was to not fade out rooms in
backdrop state, however this did not quite work, as active rooms
use the default text style from the theme (which does apply a
different backdrop style).
Add back some application CSS to fix this.
Comment 12 Florian Müllner 2015-04-23 15:33:48 UTC
Attachment 302221 [details] pushed as 7027f5e - ui: Use non-backdrop colors in room list