After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711853 - nick entry ellipsized
nick entry ellipsized
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-11 17:00 UTC by Matthias Clasen
Modified: 2013-11-19 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mainWindow: Expand nick entry (1.15 KB, patch)
2013-11-19 15:50 UTC, Carlos Soriano 		committed Details | Review

Description Matthias Clasen 2013-11-11 17:00:11 UTC 
I changed my nick from mclasen to mclasen_afk, and found that it then appeared as mclasen_... in the entry. Imo, the entry should expand, not ellipsize. There's plenty of room
Comment 1 Carlos Soriano 2013-11-19 15:50:48 UTC 
Created attachment 260256 [details] [review]
mainWindow: Expand nick entry

Acomodate nick entry to the length of the actual nick
Comment 2 Florian Müllner 2013-11-19 17:10:06 UTC 
Review of attachment 260256 [details] [review]:

I want to make nick/entry part of the chatViews eventually so entered text isn't kept when switching channels, we can then use the actual maximum nick length for the nick entry as well. For now this is good though, so let's go with that.
Minor nit in the commit message though: "accommodate for", not "acomodate to" (Something like: "Accommodate for the length of the actual nick in nick entry")
Comment 3 Carlos Soriano 2013-11-19 17:38:05 UTC 
Meh, forgot to add "bz" to the command line...

https://git.gnome.org/browse/polari/commit/?id=db645319e80555c6e277932374aeb2bed1b0fe07