After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711848 - Convert soup creation log message to debug
Convert soup creation log message to debug
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-11 14:48 UTC by Jonas Danielsson
Modified: 2013-11-13 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert soup log message to debug (741 bytes, patch)
2013-11-11 14:49 UTC, Jonas Danielsson 		committed Details | Review

Description Jonas Danielsson 2013-11-11 14:48:42 UTC 
There is no need to output this to console if we are not in debug mode (MAPS_DEBUG=1)
Comment 1 Jonas Danielsson 2013-11-11 14:49:36 UTC 
Created attachment 259568 [details] [review]
Convert soup log message to debug
Comment 2 Zeeshan Ali 2013-11-12 14:54:43 UTC 
Review of attachment 259568 [details] [review]:

ACK w/ or w/o this change.

::: src/utils.js
@@ +198,3 @@
 function _get_soup_session() {
     if (soup_session === null) {
+        debug("creating soup");

while you are at it, could you modify this to "Creating soup session.." and add a debug after the following line saying "Created soup session"?
Comment 3 Jonas Danielsson 2013-11-13 09:29:26 UTC 
Pushed with modifications suggested by Zeeshan.
Attachment 259568 [details] pushed as 6bb5d77 - Convert soup log message to debug