After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711838 - query_filesystem_info doesn't return used bytes for smb
query_filesystem_info doesn't return used bytes for smb
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: smb backend
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-11 12:55 UTC by Ross Lagerwall
Modified: 2013-11-15 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
smb: Report number of bytes used on the filesystem (2.41 KB, patch)
2013-11-11 12:59 UTC, Ross Lagerwall 		accepted-commit_now Details | Review

Description Ross Lagerwall 2013-11-11 12:55:58 UTC 
g_file_query_filesystem_info() doesn't return used bytes for smb:

$ gvfs-info -f smb://ross@localhost/ross
attributes:
  filesystem::size: 281896140800
  filesystem::free: 127877730304
  filesystem::type: cifs
  filesystem::readonly: FALSE
  gvfs::backend: smb-share
Comment 1 Ross Lagerwall 2013-11-11 12:59:14 UTC 
Created attachment 259556 [details] [review]
smb: Report number of bytes used on the filesystem

Calculated the number of bytes used by subtracting the size from the
number of bytes free, as done with local files.
Comment 2 Ondrej Holy 2013-11-15 12:35:34 UTC 
Review of attachment 259556 [details] [review]:

Looks good!
Comment 3 Ross Lagerwall 2013-11-15 15:02:04 UTC 
Pushed to master as 66f204655a7ca44a20dea2dae267c456c714c4af. Thanks!