GNOME Bugzilla – Bug 711835
Clang build in broken: void function 'cal_comp_transfer_item_to' should not return a value
Last modified: 2013-11-11 12:37:54 UTC
Commit https://git.gnome.org/browse/evolution/commit/calendar/gui?id=ed2bc85f4fe13a67aec032c8dddef0614df6419f has broken clang rebuilds: comp-util.c:916:2: error: void function 'cal_comp_transfer_item_to' should not return a value [-Wreturn-type] g_return_val_if_fail (E_IS_CAL_CLIENT (src_client), FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ comp-util.c:917:2: error: void function 'cal_comp_transfer_item_to' should not return a value [-Wreturn-type] g_return_val_if_fail (E_IS_CAL_CLIENT (dest_client), FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/glib/gmessages.h:354:3: note: expanded from macro 'g_return_val_if_fail' return (val); \ ^ ~~~~~ comp-util.c:918:2: error: void function 'cal_comp_transfer_item_to' should not return a value [-Wreturn-type] g_return_val_if_fail (icalcomp_vcal != NULL, FALSE);
Created attachment 259551 [details] [review] Bug #711835 - Clang build in broken: void function 'cal_comp_transfer_item_to' should not return a value
Review of attachment 259551 [details] [review]: not compiled, but looks correct, please commit to gnome-3-10 and master. Thanks.
Pushed 3.10: https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=066270dd3f7f4b16dd751cb78637aa224c7efc61 master (3.11.2+): https://git.gnome.org/browse/evolution/commit/?id=7a488efbb38b623b9c9658ed4350d7e263a89d71