After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711823 - Workspace indicator label is not centered vertically
Workspace indicator label is not centered vertically
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-11 09:06 UTC by Maciek Borzecki
Modified: 2013-12-14 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (1.06 KB, patch)
2013-11-11 09:06 UTC, Maciek Borzecki 		committed Details | Review
Screenshot of the questionable label align (5.54 KB, image/png)
2013-11-11 09:10 UTC, Maciek Borzecki 		  Details

Description Maciek Borzecki 2013-11-11 09:06:46 UTC 
Created attachment 259534 [details] [review]
Fix

Starting with 3.10, the label is no more centered vertically resulting in visual annoyance. The problem is not clearly visible with default theme, but it's much more pronounced if a theme using smaller fonts is enabled. Attached patch fixes the problem by setting y_align for the label.
Comment 1 Maciek Borzecki 2013-11-11 09:10:39 UTC 
Created attachment 259535 [details]
Screenshot of the questionable label align
Comment 2 Giovanni Campagna 2013-12-13 16:46:29 UTC 
Review of attachment 259534 [details] [review]:

Looks good to me. Do you have commit access?
Comment 3 Maciek Borzecki 2013-12-13 18:23:43 UTC 
(In reply to comment #2)
> Review of attachment 259534 [details] [review]:
> 
> Looks good to me. Do you have commit access?

No, unfortunately not. Can you push it to master?
Comment 4 Giovanni Campagna 2013-12-14 11:39:31 UTC 
Pushed.
Comment 5 Maciek Borzecki 2013-12-14 17:46:26 UTC 
(In reply to comment #4)
> Pushed.
Thanks!