After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711811 - Match fullscreen mode to the proposed design
Match fullscreen mode to the proposed design
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-10 22:42 UTC by Rashi Aswani
Modified: 2013-11-17 11:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Match fullscreen mode to the proposed design (2.94 KB, patch)
2013-11-15 13:01 UTC, Rashi Aswani 		needs-work Details | Review
Match fullscreen mode to the proposed design (2.68 KB, patch)
2013-11-16 00:42 UTC, Rashi Aswani 		committed Details | Review

Description Rashi Aswani 2013-11-10 22:42:31 UTC 
In fullscreen mode, the bottom toolbar is always displayed, and is superimposed over the content. When the mouse pointer is moved over the window or the user touches the window, the top bar and top toolbar are shown.
Comment 1 Rashi Aswani 2013-11-15 13:01:50 UTC 
Created attachment 259870 [details] [review]
Match fullscreen mode to the proposed design
Comment 2 David King 2013-11-15 16:00:59 UTC 
Review of attachment 259870 [details] [review]:

This doesn;t quite work, as if I press F11 to go fullscreen and then F11 again, the title bar (header bar) disappears.

::: src/cheese-window.vala
@@ +94,3 @@
   private bool is_effects_selector_active;
   private bool action_cancelled;
+  private bool is_maximize;

A better name is probably "was_maximized", as it reflects the purpose of the variable.

@@ +125,3 @@
+        if (((event.new_window_state - event.changed_mask) & Gdk.WindowState.MAXIMIZED) != 0)
+        {
+            is_maximize = true;

You can simplify this down to:

was_maximized = (((event.new_window_state - event.changed_mask)
                  & Gdk.WindowState.MAXIMIZED) != 0);
Comment 3 Rashi Aswani 2013-11-16 00:42:07 UTC 
Created attachment 259953 [details] [review]
Match fullscreen mode to the proposed design
Comment 4 David King 2013-11-17 11:08:12 UTC 
Comment on attachment 259953 [details] [review]
Match fullscreen mode to the proposed design

Thanks for the patch, I pushed a slightly-modified version to master as f04e641b30e65d8fc6f96d1eb4d8758e195aecd4.