After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711798 - giomodule: Fix leaks in module loading
giomodule: Fix leaks in module loading
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 711799
 
 
Reported: 2013-11-10 20:56 UTC by Stef Walter
Modified: 2018-05-24 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giomodule: Fix leaks in module loading (2.16 KB, patch)
2013-11-10 20:57 UTC, Stef Walter 		none Details | Review

Description Stef Walter 2013-11-10 20:56:54 UTC 
During loading giomodule leaks the various modules. This isn't a big
deal because it's done only once.
Comment 1 Stef Walter 2013-11-10 20:57:01 UTC 
Created attachment 259464 [details] [review]
giomodule: Fix leaks in module loading
Comment 2 Matthias Clasen 2013-11-11 02:17:52 UTC 
Review of attachment 259464 [details] [review]:

looks right
Comment 3 Stef Walter 2013-11-11 06:36:58 UTC 
Attachment 259464 [details] pushed as dc72039 - giomodule: Fix leaks in module loading
Comment 4 Dan Winship 2013-11-11 14:34:29 UTC 
This makes the glib-networking tests crash
Comment 5 Stef Walter 2013-11-11 16:20:34 UTC 
Yes, this is being reverted temporarily, as it seems to depend on other gcleanup patches.  I would be interested to see info about the crash though...
Comment 6 Stef Walter 2013-11-11 16:32:29 UTC 
So here's why this caused problems:

 * giomodule was leaking, perhaps on purpose (which this patched fixed)
 * GTypeModule doesn't allow itself to be finalized
 * Modules were finalizing GTypeModule in their unload code.

Fixing the leaks caused all of these to come together.

However I think that GTypeModule should be finalizable, at the very least in context of unloading a module / running gcleanup. 

I'm not an expert enough on GTypeModule to say whether GTypeModule should be finalizable at *other* times, but it should be finalizable in those contexts.

With all that said, this bug should depend on bug #711778.

 * specifically this patch: https://bug711778.bugzilla-attachments.gnome.org/attachment.cgi?id=259432
 * And likely also the GType cleanup code.
Comment 7 GNOME Infrastructure Team 2018-05-24 15:55:53 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/784.