GNOME Bugzilla – Bug 711796
glib-tap.mk: fix to actually use the TAP driver
Last modified: 2013-11-23 06:03:07 UTC
glib-tap.mk wasn't actually using the TAP driver. (See the last patch.) Fixing this pointed out a few tests that didn't pass in --tap mode. (Note in particular the second patch, which declares the reserved "..." argument to g_test_init() to be no longer reserved.)
Created attachment 259456 [details] [review] glib/tests/include: port to gtester
Created attachment 259457 [details] [review] gtestutils: add "options" to g_test_init(), make option-argv0 use gtester Declare that the previously-unused "..." argument to g_test_init() is actually a NULL-terminated list of strings indicating testing options, and add an option "no_g_set_prgname", which keeps g_test_init() from calling g_set_prgname(). Then we can port glib/tests/option-argv0 to use gtester, by passing that option.
Created attachment 259458 [details] [review] gio/tests: basic-application is a helper program, not a test
Created attachment 259459 [details] [review] gio/tests: fix output of gdbus-proxy-threads and gdbus-threading Make gdbus-proxy-threads and gdbus-threading print a newline at the end of their progress strings, to avoid messing up their TAP-format output.
Created attachment 259460 [details] [review] glib-tap.mk: fix to actually use the TAP driver The Makefile rules in glib-tap.mk were copied from an example that assumed that all the test programs had names ending in ".test", so they didn't actually have any effect for us and resulted in us still using the standard automake test driver. Fix this so we actually do use TAP now.
Review of attachment 259456 [details] [review]: ok
Review of attachment 259457 [details] [review]: ::: glib/gtestutils.c @@ +630,3 @@ }; const GTestConfig * const g_test_config_vars = &mutable_test_config_vars; +static GHashTable *test_options; hmm, as long as we only have a single option, I would probably just go with a static gboolean no_g_set_prgname
Review of attachment 259458 [details] [review]: ok
Review of attachment 259459 [details] [review]: ok
Review of attachment 259460 [details] [review]: oops, ok
Attachment 259456 [details] pushed as f733075 - glib/tests/include: port to gtester Attachment 259457 [details] pushed as 41eacde - gtestutils: add "options" to g_test_init(), make option-argv0 use gtester Attachment 259458 [details] pushed as c762a3a - gio/tests: basic-application is a helper program, not a test Attachment 259459 [details] pushed as 8f5b40c - gio/tests: fix output of gdbus-proxy-threads and gdbus-threading Attachment 259460 [details] pushed as be231c6 - glib-tap.mk: fix to actually use the TAP driver